From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIbFy-0004ba-VF for qemu-devel@nongnu.org; Tue, 15 May 2018 10:48:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIbFw-0006oR-E6 for qemu-devel@nongnu.org; Tue, 15 May 2018 10:48:51 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:43998 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fIbFw-0006oK-8k for qemu-devel@nongnu.org; Tue, 15 May 2018 10:48:48 -0400 Date: Tue, 15 May 2018 16:48:45 +0200 From: Igor Mammedov Message-ID: <20180515164845.4865b9ac@redhat.com> In-Reply-To: <20180515142450.luz3onyxdfrrqsqb@kamzik.brq.redhat.com> References: <1526380858-44651-1-git-send-email-imammedo@redhat.com> <20180515142450.luz3onyxdfrrqsqb@kamzik.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] numa: clarify error message when node index is out of range in -numa dist, ... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: he.chen@linux.intel.com, qemu-devel@nongnu.org, ehabkost@redhat.com On Tue, 15 May 2018 16:24:50 +0200 Andrew Jones wrote: > Pretty long patch summary line. Do we not try to limit that? > > On Tue, May 15, 2018 at 12:40:58PM +0200, Igor Mammedov wrote: > > When using following CLI: > > -numa dist,src=128,dst=1,val=20 > > user getsi a rather confusing error message: > > gets > > > "Invalid node 128, max possible could be 128" > > > > Where 128 is number of nodes that QEMU supports (MAX_NODES), > > while src/dst is an index up to that limit, so it should be > > MAX_NODES - 1 in error message. > > Make error message to explicitly state valid range for node > > index to be more clear. > > > > Signed-off-by: Igor Mammedov > > --- > > numa.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/numa.c b/numa.c > > index a3637cc..dedc149 100644 > > --- a/numa.c > > +++ b/numa.c > > @@ -142,8 +142,8 @@ static void parse_numa_distance(NumaDistOptions *dist, Error **errp) > > > > if (src >= MAX_NODES || dst >= MAX_NODES) { > > error_setg(errp, > > - "Invalid node %d, max possible could be %d", > > - MAX(src, dst), MAX_NODES); > > + "Invalid node %d, should be in range [0 - %d]", > > How about "Invalid node %d. The valid node range is [0, %d]." ? I'll fix up and resend v2 > > > + MAX(src, dst), MAX_NODES - 1); > > return; > > } > > > > -- > > 2.7.4 > > > > > > Besides the nits > > Reviewed-by: Andrew Jones Thanks! > > Thanks, > drew >