qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Aurelien Jarno <aurelien@aurel32.net>,
	Yongbok Kim <yongbok.kim@mips.com>
Subject: [Qemu-devel] [PULL 17/28] target/mips: Remove floatX_maybe_silence_nan from conversions
Date: Wed, 16 May 2018 08:52:32 -0700	[thread overview]
Message-ID: <20180516155243.16937-18-richard.henderson@linaro.org> (raw)
In-Reply-To: <20180516155243.16937-1-richard.henderson@linaro.org>

This is now handled properly by the generic softfloat code.

Cc: Aurelien Jarno <aurelien@aurel32.net>
Cc: Yongbok Kim <yongbok.kim@mips.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/mips/msa_helper.c | 4 ----
 target/mips/op_helper.c  | 2 --
 2 files changed, 6 deletions(-)

diff --git a/target/mips/msa_helper.c b/target/mips/msa_helper.c
index 8fb7a369ca..c74e3cdc65 100644
--- a/target/mips/msa_helper.c
+++ b/target/mips/msa_helper.c
@@ -1615,7 +1615,6 @@ static inline float16 float16_from_float32(int32_t a, flag ieee,
       float16 f_val;
 
       f_val = float32_to_float16((float32)a, ieee, status);
-      f_val = float16_maybe_silence_nan(f_val, status);
 
       return a < 0 ? (f_val | (1 << 15)) : f_val;
 }
@@ -1625,7 +1624,6 @@ static inline float32 float32_from_float64(int64_t a, float_status *status)
       float32 f_val;
 
       f_val = float64_to_float32((float64)a, status);
-      f_val = float32_maybe_silence_nan(f_val, status);
 
       return a < 0 ? (f_val | (1 << 31)) : f_val;
 }
@@ -1636,7 +1634,6 @@ static inline float32 float32_from_float16(int16_t a, flag ieee,
       float32 f_val;
 
       f_val = float16_to_float32((float16)a, ieee, status);
-      f_val = float32_maybe_silence_nan(f_val, status);
 
       return a < 0 ? (f_val | (1 << 31)) : f_val;
 }
@@ -1646,7 +1643,6 @@ static inline float64 float64_from_float32(int32_t a, float_status *status)
       float64 f_val;
 
       f_val = float32_to_float64((float64)a, status);
-      f_val = float64_maybe_silence_nan(f_val, status);
 
       return a < 0 ? (f_val | (1ULL << 63)) : f_val;
 }
diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c
index 798cdad030..9025f42366 100644
--- a/target/mips/op_helper.c
+++ b/target/mips/op_helper.c
@@ -2700,7 +2700,6 @@ uint64_t helper_float_cvtd_s(CPUMIPSState *env, uint32_t fst0)
     uint64_t fdt2;
 
     fdt2 = float32_to_float64(fst0, &env->active_fpu.fp_status);
-    fdt2 = float64_maybe_silence_nan(fdt2, &env->active_fpu.fp_status);
     update_fcr31(env, GETPC());
     return fdt2;
 }
@@ -2790,7 +2789,6 @@ uint32_t helper_float_cvts_d(CPUMIPSState *env, uint64_t fdt0)
     uint32_t fst2;
 
     fst2 = float64_to_float32(fdt0, &env->active_fpu.fp_status);
-    fst2 = float32_maybe_silence_nan(fst2, &env->active_fpu.fp_status);
     update_fcr31(env, GETPC());
     return fst2;
 }
-- 
2.17.0

  parent reply	other threads:[~2018-05-16 15:53 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 15:52 [Qemu-devel] [PULL 00/28] softfloat patch roundup Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 01/28] fpu/softfloat: Fix conversion from uint64 to float128 Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 02/28] fpu/softfloat: Merge NO_SIGNALING_NANS definitions Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 03/28] fpu/softfloat: Split floatXX_silence_nan from floatXX_maybe_silence_nan Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 04/28] fpu/softfloat: Move softfloat-specialize.h below FloatParts definition Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 05/28] fpu/softfloat: Canonicalize NaN fraction Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 06/28] fpu/softfloat: Introduce parts_is_snan_frac Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 07/28] fpu/softfloat: Replace float_class_dnan with parts_default_nan Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 08/28] fpu/softfloat: Replace float_class_msnan with parts_silence_nan Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 09/28] target/arm: convert conversion helpers to fpst/ahp_flag Richard Henderson
2018-05-17 10:16   ` Peter Maydell
2018-05-17 22:19     ` Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 10/28] target/arm: squash FZ16 behaviour for conversions Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 11/28] fpu/softfloat: Partial support for ARM Alternative half-precision Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 12/28] fpu/softfloat: re-factor float to float conversions Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 13/28] target/arm: Use floatX_silence_nan when we have already checked for SNaN Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 14/28] target/arm: Remove floatX_maybe_silence_nan from conversions Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 15/28] target/hppa: " Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 16/28] target/m68k: Use floatX_silence_nan when we have already checked for SNaN Richard Henderson
2018-05-16 15:52 ` Richard Henderson [this message]
2018-05-16 15:52 ` [Qemu-devel] [PULL 18/28] target/riscv: Remove floatX_maybe_silence_nan from conversions Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 19/28] target/s390x: " Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 20/28] fpu/softfloat: Use float*_silence_nan in propagateFloat*NaN Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 21/28] fpu/softfloat: Remove floatX_maybe_silence_nan Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 22/28] fpu/softfloat: Specialize on snan_bit_is_one Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 23/28] fpu/softfloat: Make is_nan et al available to softfloat-specialize.h Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 24/28] fpu/softfloat: Pass FloatClass to pickNaN Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 25/28] fpu/softfloat: Pass FloatClass to pickNaNMulAdd Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 26/28] fpu/softfloat: Define floatN_default_nan in terms of parts_default_nan Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 27/28] fpu/softfloat: Clean up parts_default_nan Richard Henderson
2018-05-16 15:52 ` [Qemu-devel] [PULL 28/28] fpu/softfloat: Define floatN_silence_nan in terms of parts_silence_nan Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180516155243.16937-18-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=yongbok.kim@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).