* [Qemu-devel] [PATCH] nfs: Fix error path in nfs_options_qdict_to_qapi()
@ 2018-05-16 16:10 Kevin Wolf
2018-05-16 16:49 ` Eric Blake
2018-05-16 17:10 ` Jeff Cody
0 siblings, 2 replies; 3+ messages in thread
From: Kevin Wolf @ 2018-05-16 16:10 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, mreitz, jcody, qemu-devel
Don't throw away local_err, but propagate it to errp.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/nfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/nfs.c b/block/nfs.c
index d6364d28bb..3349b67a76 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -571,6 +571,7 @@ static BlockdevOptionsNfs *nfs_options_qdict_to_qapi(QDict *options,
qobject_unref(crumpled);
if (local_err) {
+ error_propagate(errp, local_err);
return NULL;
}
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] nfs: Fix error path in nfs_options_qdict_to_qapi()
2018-05-16 16:10 [Qemu-devel] [PATCH] nfs: Fix error path in nfs_options_qdict_to_qapi() Kevin Wolf
@ 2018-05-16 16:49 ` Eric Blake
2018-05-16 17:10 ` Jeff Cody
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2018-05-16 16:49 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: jcody, qemu-devel, mreitz
On 05/16/2018 11:10 AM, Kevin Wolf wrote:
> Don't throw away local_err, but propagate it to errp.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/nfs.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/block/nfs.c b/block/nfs.c
> index d6364d28bb..3349b67a76 100644
> --- a/block/nfs.c
> +++ b/block/nfs.c
> @@ -571,6 +571,7 @@ static BlockdevOptionsNfs *nfs_options_qdict_to_qapi(QDict *options,
> qobject_unref(crumpled);
>
> if (local_err) {
> + error_propagate(errp, local_err);
> return NULL;
> }
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] nfs: Fix error path in nfs_options_qdict_to_qapi()
2018-05-16 16:10 [Qemu-devel] [PATCH] nfs: Fix error path in nfs_options_qdict_to_qapi() Kevin Wolf
2018-05-16 16:49 ` Eric Blake
@ 2018-05-16 17:10 ` Jeff Cody
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Cody @ 2018-05-16 17:10 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-block, mreitz, qemu-devel
On Wed, May 16, 2018 at 06:10:34PM +0200, Kevin Wolf wrote:
> Don't throw away local_err, but propagate it to errp.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/nfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/nfs.c b/block/nfs.c
> index d6364d28bb..3349b67a76 100644
> --- a/block/nfs.c
> +++ b/block/nfs.c
> @@ -571,6 +571,7 @@ static BlockdevOptionsNfs *nfs_options_qdict_to_qapi(QDict *options,
> qobject_unref(crumpled);
>
> if (local_err) {
> + error_propagate(errp, local_err);
> return NULL;
> }
>
> --
> 2.13.6
>
Thanks,
Applied to my block branch:
git://github.com/codyprime/qemu-kvm-jtc block
-Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-16 17:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-16 16:10 [Qemu-devel] [PATCH] nfs: Fix error path in nfs_options_qdict_to_qapi() Kevin Wolf
2018-05-16 16:49 ` Eric Blake
2018-05-16 17:10 ` Jeff Cody
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).