From: Jeff Cody <jcody@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, mreitz@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] nfs: Fix error path in nfs_options_qdict_to_qapi()
Date: Wed, 16 May 2018 13:10:38 -0400 [thread overview]
Message-ID: <20180516171038.GC6999@localhost.localdomain> (raw)
In-Reply-To: <20180516161034.27440-1-kwolf@redhat.com>
On Wed, May 16, 2018 at 06:10:34PM +0200, Kevin Wolf wrote:
> Don't throw away local_err, but propagate it to errp.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/nfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/nfs.c b/block/nfs.c
> index d6364d28bb..3349b67a76 100644
> --- a/block/nfs.c
> +++ b/block/nfs.c
> @@ -571,6 +571,7 @@ static BlockdevOptionsNfs *nfs_options_qdict_to_qapi(QDict *options,
> qobject_unref(crumpled);
>
> if (local_err) {
> + error_propagate(errp, local_err);
> return NULL;
> }
>
> --
> 2.13.6
>
Thanks,
Applied to my block branch:
git://github.com/codyprime/qemu-kvm-jtc block
-Jeff
prev parent reply other threads:[~2018-05-16 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 16:10 [Qemu-devel] [PATCH] nfs: Fix error path in nfs_options_qdict_to_qapi() Kevin Wolf
2018-05-16 16:49 ` Eric Blake
2018-05-16 17:10 ` Jeff Cody [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516171038.GC6999@localhost.localdomain \
--to=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).