From: Eduardo Habkost <ehabkost@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com, eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4] numa: clarify error message when node index is out of range in -numa dist, ...
Date: Wed, 16 May 2018 14:41:46 -0300 [thread overview]
Message-ID: <20180516174146.GO25013@localhost.localdomain> (raw)
In-Reply-To: <1526483174-169008-1-git-send-email-imammedo@redhat.com>
On Wed, May 16, 2018 at 05:06:14PM +0200, Igor Mammedov wrote:
> When using following CLI:
> -numa dist,src=128,dst=1,val=20
> user gets a rather confusing error message:
> "Invalid node 128, max possible could be 128"
>
> Where 128 is number of nodes that QEMU supports (MAX_NODES),
> while src/dst is an index up to that limit, so it should be
> MAX_NODES - 1 in error message.
> Make error message to explicitly state valid range for node
> index to be more clear.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Queued, thanks.
--
Eduardo
prev parent reply other threads:[~2018-05-16 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 15:06 [Qemu-devel] [PATCH v4] numa: clarify error message when node index is out of range in -numa dist, Igor Mammedov
2018-05-16 15:15 ` Eric Blake
2018-05-16 17:41 ` Eduardo Habkost [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516174146.GO25013@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).