qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, richard.henderson@linaro.org,
	frederic.konrad@adacore.com, alistair@alistair23.me,
	frasse.iglesias@gmail.com, sstabellini@kernel.org,
	sai.pavan.boddu@xilinx.com, edgar.iglesias@xilinx.com
Subject: [Qemu-devel] [PATCH v3 09/38] target-microblaze: Conditionalize setting of PVR11_USE_MMU
Date: Wed, 16 May 2018 20:51:17 +0200	[thread overview]
Message-ID: <20180516185146.30708-10-edgar.iglesias@gmail.com> (raw)
In-Reply-To: <20180516185146.30708-1-edgar.iglesias@gmail.com>

From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

Conditionalize setting of PVR11_USE_MMU on the use_mmu
CPU property, otherwise we may incorrectly advertise an
MMU via PVR when the core in fact has none.

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
 target/microblaze/cpu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c
index 06476f6efc..6fdf0fd223 100644
--- a/target/microblaze/cpu.c
+++ b/target/microblaze/cpu.c
@@ -201,7 +201,8 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **errp)
                                         PVR5_DCACHE_WRITEBACK_MASK : 0;
 
     env->pvr.regs[10] = 0x0c000000; /* Default to spartan 3a dsp family.  */
-    env->pvr.regs[11] = PVR11_USE_MMU | (16 << 17);
+    env->pvr.regs[11] = cpu->cfg.use_mmu ? PVR11_USE_MMU : 0 |
+                        16 << 17;
 
     mcc->parent_realize(dev, errp);
 }
-- 
2.14.1

  parent reply	other threads:[~2018-05-16 18:52 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 18:51 [Qemu-devel] [PATCH v3 00/38] target-microblaze: Add support for Extended Addressing Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 01/38] target-microblaze: dec_load: Use bool instead of unsigned int Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 02/38] target-microblaze: dec_store: " Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 03/38] target-microblaze: compute_ldst_addr: Use bool instead of int Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 04/38] target-microblaze: Fallback to our latest CPU version Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 05/38] target-microblaze: Correct special register array sizes Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 06/38] target-microblaze: Correct the PVR array size Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 07/38] target-microblaze: Tighten up TCGv_i32 vs TCGv type usage Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 08/38] target-microblaze: Remove USE_MMU PVR checks Edgar E. Iglesias
2018-05-16 18:51 ` Edgar E. Iglesias [this message]
2018-05-17 17:26   ` [Qemu-devel] [PATCH v3 09/38] target-microblaze: Conditionalize setting of PVR11_USE_MMU Richard Henderson
2018-05-17 18:00     ` Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 10/38] target-microblaze: Bypass MMU with MMU_NOMMU_IDX Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 11/38] target-microblaze: Make compute_ldst_addr always use a temp Edgar E. Iglesias
2018-05-17 14:39   ` Philippe Mathieu-Daudé
2018-05-17 16:41     ` Edgar E. Iglesias
2018-05-17 17:14       ` Philippe Mathieu-Daudé
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 12/38] target-microblaze: Remove pointer indirection for ld/st addresses Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 13/38] target-microblaze: Use TCGv for load/store addresses Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 14/38] target-microblaze: Name special registers we support Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 15/38] target-microblaze: Break out trap_userspace() Edgar E. Iglesias
2018-05-17 14:52   ` Philippe Mathieu-Daudé
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 16/38] target-microblaze: Break out trap_illegal() Edgar E. Iglesias
2018-05-17 14:56   ` Philippe Mathieu-Daudé
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 17/38] target-microblaze: dec_msr: Use bool and extract32 Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 18/38] target-microblaze: dec_msr: Reuse more code when reg-decoding Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 19/38] target-microblaze: dec_msr: Fix MTS to FSR Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 20/38] target-microblaze: Make special registers 64-bit Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 21/38] target-microblaze: Setup for 64bit addressing Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 23/38] target-microblaze: Implement MFSE EAR Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 24/38] target-microblaze: mmu: Add R_TBLX_MISS macros Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 25/38] target-microblaze: mmu: Remove unused register state Edgar E. Iglesias
2018-05-17 15:15   ` Philippe Mathieu-Daudé
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 26/38] target-microblaze: mmu: Prepare for 64-bit addresses Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 27/38] target-microblaze: mmu: Add a configurable output address mask Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 28/38] target-microblaze: dec_msr: Plug a temp leak Edgar E. Iglesias
2018-05-17 13:58   ` Philippe Mathieu-Daudé
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 29/38] target-microblaze: Add support for extended access to TLBLO Edgar E. Iglesias
2018-05-16 23:48   ` Alistair Francis
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 30/38] target-microblaze: Allow address sizes between 32 and 64 bits Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 31/38] target-microblaze: Simplify address computation using tcg_gen_addi_i32() Edgar E. Iglesias
2018-05-17 18:19   ` Philippe Mathieu-Daudé
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 32/38] target-microblaze: mmu: Cleanup debug log messages Edgar E. Iglesias
2018-05-16 23:42   ` Alistair Francis
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 33/38] target-microblaze: Use table based condition-codes conversion Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 34/38] target-microblaze: Remove argument b in eval_cc() Edgar E. Iglesias
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 35/38] target-microblaze: Convert env_btarget to i64 Edgar E. Iglesias
2018-05-17 14:28   ` Philippe Mathieu-Daudé
2018-05-17 17:34   ` Richard Henderson
2018-05-17 18:03     ` Edgar E. Iglesias
2018-05-17 20:48       ` Richard Henderson
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 36/38] target-microblaze: Use tcg_gen_movcond in eval_cond_jmp Edgar E. Iglesias
2018-05-17 14:22   ` Philippe Mathieu-Daudé
2018-05-17 14:48     ` Philippe Mathieu-Daudé
2018-05-17 16:42       ` Edgar E. Iglesias
2018-05-17 17:24         ` Philippe Mathieu-Daudé
2018-05-17 17:36   ` Richard Henderson
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 37/38] target-microblaze: cpu_mmu_index: Fixup indentation Edgar E. Iglesias
2018-05-16 23:49   ` Alistair Francis
2018-05-17 17:38   ` Richard Henderson
2018-05-16 18:51 ` [Qemu-devel] [PATCH v3 38/38] target-microblaze: Consolidate MMU enabled checks Edgar E. Iglesias
2018-05-16 23:51   ` Alistair Francis
2018-05-17 17:39   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180516185146.30708-10-edgar.iglesias@gmail.com \
    --to=edgar.iglesias@gmail.com \
    --cc=alistair@alistair23.me \
    --cc=edgar.iglesias@xilinx.com \
    --cc=frasse.iglesias@gmail.com \
    --cc=frederic.konrad@adacore.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sai.pavan.boddu@xilinx.com \
    --cc=sstabellini@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).