qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: cota@braap.org, famz@redhat.com, berrange@redhat.com,
	f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com,
	aurelien@aurel32.net, agraf@suse.de
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PATCH v4 11/49] docker: Makefile.include introduce DOCKER_SCRIPT
Date: Thu, 17 May 2018 18:46:40 +0100	[thread overview]
Message-ID: <20180517174718.10107-12-alex.bennee@linaro.org> (raw)
In-Reply-To: <20180517174718.10107-1-alex.bennee@linaro.org>

Define this in one place to make it easy to re-use.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 tests/docker/Makefile.include | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index de87341528..6a5aa9ec71 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -14,6 +14,8 @@ DOCKER_TESTS := $(notdir $(shell \
 
 DOCKER_TOOLS := travis
 
+DOCKER_SCRIPT=$(SRC_PATH)/tests/docker/docker.py
+
 TESTS ?= %
 IMAGES ?= %
 
@@ -37,7 +39,7 @@ docker-image-%: $(DOCKER_FILES_DIR)/%.docker
 		echo WARNING: EXECUTABLE is not set, debootstrap may fail. 2>&1 ; \
 	fi
 	$(call quiet-command,\
-		$(SRC_PATH)/tests/docker/docker.py build qemu:$* $< \
+		$(DOCKER_SCRIPT) build qemu:$* $< \
 		$(if $V,,--quiet) $(if $(NOCACHE),--no-cache) \
 		$(if $(NOUSER),,--add-current-user) \
 		$(if $(EXTRA_FILES),--extra-files $(EXTRA_FILES))\
@@ -129,11 +131,11 @@ docker-run: docker-qemu-src
 	fi
 	$(if $(EXECUTABLE),						\
 		$(call quiet-command,					\
-			$(SRC_PATH)/tests/docker/docker.py update 	\
+			$(DOCKER_SCRIPT) update 			\
 			$(IMAGE) $(EXECUTABLE),				\
 			"  COPYING $(EXECUTABLE) to $(IMAGE)"))
 	$(call quiet-command,						\
-		$(SRC_PATH)/tests/docker/docker.py run 			\
+		$(DOCKER_SCRIPT) run 					\
 			$(if $(NOUSER),,-u $(shell id -u)) 		\
 			--security-opt seccomp=unconfined		\
 			$(if $V,,--rm) 					\
@@ -163,4 +165,4 @@ docker-run-%:
 	@$(MAKE) docker-run TEST=$(CMD) IMAGE=qemu:$(IMAGE)
 
 docker-clean:
-	$(call quiet-command, $(SRC_PATH)/tests/docker/docker.py clean)
+	$(call quiet-command, $(DOCKER_SCRIPT) clean)
-- 
2.17.0

  parent reply	other threads:[~2018-05-17 17:47 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 17:46 [Qemu-devel] [PATCH v4 00/49] fix building of tests/tcg Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 01/49] docker: add "probe" command for configure Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 02/49] configure: add test for docker availability Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 03/49] configure: add support for --cross-cc-FOO Alex Bennée
2018-05-17 18:19   ` Richard Henderson
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 04/49] configure: move i386_cc to cross_cc_i386 Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 05/49] configure: allow user to specify --cross-cc-cflags-foo= Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 06/49] configure: set cross_cc_FOO for host compiler Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 07/49] Makefile: Rename TARGET_DIRS to TARGET_LIST Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 08/49] docker: Add "cc" subcommand Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 09/49] docker: extend "cc" command to accept compiler Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 10/49] docker: allow "cc" command to run in user context Alex Bennée
2018-05-17 17:46 ` Alex Bennée [this message]
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 12/49] tests/tcg: move architecture independent tests into subdir Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 13/49] tests/tcg/multiarch: Build fix for linux-test Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 14/49] tests/tcg/multiarch: enable additional linux-test tests Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 15/49] tests/tcg/multiarch: move most output to stdout Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 16/49] tests/tcg: move i386 specific tests into subdir Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 17/49] docker: Add fedora-i386-cross image Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 18/49] tests/tcg: enable building for i386 Alex Bennée
2018-05-18 11:28   ` Paolo Bonzini
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 19/49] tests/tcg/i386: Build fix for hello-i386 Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 20/49] tests/tcg/i386: fix test-i386 Alex Bennée
2018-05-17 19:04   ` Eric Blake
2018-05-17 19:57     ` Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 21/49] tests/tcg/i386: add runner for test-i386-fprem Alex Bennée
2018-05-18 11:30   ` Paolo Bonzini
2018-05-18 12:27     ` Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 22/49] tests/tcg/i386: disable i386 version of test-i386-ssse Alex Bennée
2018-05-17 19:56   ` Richard Henderson
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 23/49] tests/tcg/x86_64: add Makefile.target Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 24/49] tests/tcg/i386/test-i386: use modern vector_size attributes Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 25/49] tests/tcg/i386/test-i386: fix printf format Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 26/49] tests/tcg: move ARM specific tests into subdir Alex Bennée
2018-05-18 15:26   ` Philippe Mathieu-Daudé
2018-05-18 15:58     ` Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 27/49] tests/tcg: enable building for ARM Alex Bennée
2018-05-18 15:28   ` Philippe Mathieu-Daudé
2018-05-18 15:48     ` Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 28/49] tests/tcg/arm: fix up test-arm-iwmmxt test Alex Bennée
2018-05-17 20:15   ` Richard Henderson
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 29/49] tests/tcg/arm: disable -p 32768 mmap test Alex Bennée
2018-05-17 20:20   ` Richard Henderson
2018-05-17 21:24     ` Alex Bennée
2018-05-17 21:34       ` Richard Henderson
2018-05-18  3:47         ` Philippe Mathieu-Daudé
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 30/49] tests/tcg: enable building for AArch64 Alex Bennée
2018-05-17 20:26   ` Richard Henderson
2018-05-18 14:57   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 31/49] tests/tcg/aarch64: add Makefile.target Alex Bennée
2018-05-17 20:28   ` Richard Henderson
2018-05-17 21:25     ` Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 32/49] tests/tcg/arm: add fcvt test cases for AArch32/64 Alex Bennée
2018-05-17 20:30   ` Richard Henderson
2018-05-18  3:45     ` Philippe Mathieu-Daudé
2018-05-18  8:16       ` Alex Bennée
2018-05-18 14:53         ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 33/49] tests/tcg: move MIPS specific tests into subdir Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 34/49] tests/tcg: enable building for MIPS Alex Bennée
2018-05-18 14:49   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 35/49] tests/tcg/mips: include common mips hello-mips Alex Bennée
2018-05-18 14:49   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 36/49] tests/tcg: enable building for s390x Alex Bennée
2018-05-18 12:04   ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 37/49] tests/tcg: enable building for ppc64 Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 38/49] tests/tcg: enable building for Alpha Alex Bennée
2018-05-18 14:21   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 39/49] tests/tcg/alpha: add Alpha specific tests Alex Bennée
2018-05-17 20:41   ` Richard Henderson
2018-05-18 14:25   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 40/49] tests/tcg: enable building for HPPA Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 41/49] tests/tcg: enable building for m68k Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 42/49] tests/tcg: enable building for sh4 Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 43/49] tests/tcg: enable building for sparc64 Alex Bennée
2018-05-18 14:28   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 44/49] tests/tcg: enable building for mips64 Alex Bennée
2018-05-18 14:26   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 45/49] tests/tcg: enable building for RISCV64 Alex Bennée
2018-05-18 14:24   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 46/49] tests/tcg/Makefile: update to be called from Makefile.target Alex Bennée
2018-05-17 20:43   ` Richard Henderson
2018-05-18 14:49   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 47/49] Makefile.target: add (clean-/build-)guest-tests targets Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 48/49] tests/Makefile.include: add [build|clean|check]-tcg targets Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 49/49] tests/tcg: override runners for broken tests (!UPSTREAM) Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180517174718.10107-12-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=balrogg@gmail.com \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).