qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: cota@braap.org, famz@redhat.com, berrange@redhat.com,
	f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com,
	aurelien@aurel32.net, agraf@suse.de
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH v4 39/49] tests/tcg/alpha: add Alpha specific tests
Date: Thu, 17 May 2018 18:47:08 +0100	[thread overview]
Message-ID: <20180517174718.10107-40-alex.bennee@linaro.org> (raw)
In-Reply-To: <20180517174718.10107-1-alex.bennee@linaro.org>

These tests did use their own crt.o stub however that is a little
stone age so we drop crt.S and just statically link to the cross
compilers libraries.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
v4
  - drop crt.s
  - drop skipping of threadtest
  - drop write() hack, include unistd.h
---
 tests/tcg/alpha/Makefile        | 35 ---------------------------------
 tests/tcg/alpha/Makefile.target | 15 ++++++++++++++
 tests/tcg/alpha/crt.s           | 26 ------------------------
 tests/tcg/alpha/hello-alpha.c   |  2 ++
 tests/tcg/alpha/test-cond.c     |  1 +
 tests/tcg/alpha/test-ovf.c      |  2 ++
 6 files changed, 20 insertions(+), 61 deletions(-)
 delete mode 100644 tests/tcg/alpha/Makefile
 create mode 100644 tests/tcg/alpha/Makefile.target
 delete mode 100644 tests/tcg/alpha/crt.s

diff --git a/tests/tcg/alpha/Makefile b/tests/tcg/alpha/Makefile
deleted file mode 100644
index 2b1f03d048..0000000000
--- a/tests/tcg/alpha/Makefile
+++ /dev/null
@@ -1,35 +0,0 @@
-CROSS=alpha-linux-gnu-
-CC=$(CROSS)gcc
-AS=$(CROSS)as
-
-SIM=../../alpha-linux-user/qemu-alpha
-
-CFLAGS=-O
-LINK=$(CC) -o $@ crt.o $< -nostdlib
-
-TESTS=test-cond test-cmov
-
-all: hello-alpha $(TESTS)
-
-hello-alpha: hello-alpha.o crt.o
-	$(LINK)
-
-test-cond: test-cond.o crt.o
-	$(LINK)
-
-test-cmov.o: test-cond.c
-	$(CC) -c $(CFLAGS) -DTEST_CMOV -o $@ $<
-
-test-cmov: test-cmov.o crt.o
-	$(LINK)
-
-test-ovf: test-ovf.o crt.o
-	$(LINK)
-
-check: $(TESTS)
-	for f in $(TESTS); do $(SIM) $$f || exit 1; done
-
-clean:
-	$(RM) *.o *~ hello-alpha $(TESTS)
-
-.PHONY: clean all check
diff --git a/tests/tcg/alpha/Makefile.target b/tests/tcg/alpha/Makefile.target
new file mode 100644
index 0000000000..b253cee1fc
--- /dev/null
+++ b/tests/tcg/alpha/Makefile.target
@@ -0,0 +1,15 @@
+# -*- Mode: makefile -*-
+#
+# Alpha specific tweaks
+
+ALPHA_SRC=$(SRC_PATH)/tests/tcg/alpha
+VPATH+=$(ALPHA_SRC)
+
+ALPHA_TESTS=hello-alpha test-cond test-cmov test-ovf
+TESTS+=$(ALPHA_TESTS)
+
+test-cmov: EXTRA_CFLAGS=-DTEST_CMOV
+test-cmov: test-cond.c
+	$(CC) $(CFLAGS) $(EXTRA_CFLAGS) $< -o $@ $(LDFLAGS)
+
+run-test-cmov: test-cmov
diff --git a/tests/tcg/alpha/crt.s b/tests/tcg/alpha/crt.s
deleted file mode 100644
index 31af8825bc..0000000000
--- a/tests/tcg/alpha/crt.s
+++ /dev/null
@@ -1,26 +0,0 @@
-	.text
-
-	.globl _start
-	.ent _start,0
-_start:
-	.frame $15,0,$15
-	br $29,1f
-1:	ldgp $29, 0($29)
-	.prologue 0
-	ldq $27,main($29) !literal!1
-	jsr $26,($27)
-	or $0,$0,$16
-	.end _start
-
-	.globl _exit
-_exit:
-	lda $0,1
-	callsys
-
-	call_pal 0
-
-	.globl write
-write:
-	lda $0,4
-	callsys
-	ret
diff --git a/tests/tcg/alpha/hello-alpha.c b/tests/tcg/alpha/hello-alpha.c
index 79892e6522..84e43b2fc4 100644
--- a/tests/tcg/alpha/hello-alpha.c
+++ b/tests/tcg/alpha/hello-alpha.c
@@ -1,3 +1,5 @@
+#include <unistd.h>
+
 int main (void)
 {
   write (1, "hello\n", 6);
diff --git a/tests/tcg/alpha/test-cond.c b/tests/tcg/alpha/test-cond.c
index 74adffaa69..e625313b3e 100644
--- a/tests/tcg/alpha/test-cond.c
+++ b/tests/tcg/alpha/test-cond.c
@@ -1,3 +1,4 @@
+#include <unistd.h>
 
 #ifdef TEST_CMOV
 
diff --git a/tests/tcg/alpha/test-ovf.c b/tests/tcg/alpha/test-ovf.c
index 01c80e7525..17892f1e89 100644
--- a/tests/tcg/alpha/test-ovf.c
+++ b/tests/tcg/alpha/test-ovf.c
@@ -1,3 +1,5 @@
+#include <unistd.h>
+
 static long test_subqv (long a, long b)
 {
   long res;
-- 
2.17.0

  parent reply	other threads:[~2018-05-17 17:54 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 17:46 [Qemu-devel] [PATCH v4 00/49] fix building of tests/tcg Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 01/49] docker: add "probe" command for configure Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 02/49] configure: add test for docker availability Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 03/49] configure: add support for --cross-cc-FOO Alex Bennée
2018-05-17 18:19   ` Richard Henderson
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 04/49] configure: move i386_cc to cross_cc_i386 Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 05/49] configure: allow user to specify --cross-cc-cflags-foo= Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 06/49] configure: set cross_cc_FOO for host compiler Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 07/49] Makefile: Rename TARGET_DIRS to TARGET_LIST Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 08/49] docker: Add "cc" subcommand Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 09/49] docker: extend "cc" command to accept compiler Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 10/49] docker: allow "cc" command to run in user context Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 11/49] docker: Makefile.include introduce DOCKER_SCRIPT Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 12/49] tests/tcg: move architecture independent tests into subdir Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 13/49] tests/tcg/multiarch: Build fix for linux-test Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 14/49] tests/tcg/multiarch: enable additional linux-test tests Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 15/49] tests/tcg/multiarch: move most output to stdout Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 16/49] tests/tcg: move i386 specific tests into subdir Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 17/49] docker: Add fedora-i386-cross image Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 18/49] tests/tcg: enable building for i386 Alex Bennée
2018-05-18 11:28   ` Paolo Bonzini
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 19/49] tests/tcg/i386: Build fix for hello-i386 Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 20/49] tests/tcg/i386: fix test-i386 Alex Bennée
2018-05-17 19:04   ` Eric Blake
2018-05-17 19:57     ` Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 21/49] tests/tcg/i386: add runner for test-i386-fprem Alex Bennée
2018-05-18 11:30   ` Paolo Bonzini
2018-05-18 12:27     ` Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 22/49] tests/tcg/i386: disable i386 version of test-i386-ssse Alex Bennée
2018-05-17 19:56   ` Richard Henderson
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 23/49] tests/tcg/x86_64: add Makefile.target Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 24/49] tests/tcg/i386/test-i386: use modern vector_size attributes Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 25/49] tests/tcg/i386/test-i386: fix printf format Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 26/49] tests/tcg: move ARM specific tests into subdir Alex Bennée
2018-05-18 15:26   ` Philippe Mathieu-Daudé
2018-05-18 15:58     ` Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 27/49] tests/tcg: enable building for ARM Alex Bennée
2018-05-18 15:28   ` Philippe Mathieu-Daudé
2018-05-18 15:48     ` Alex Bennée
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 28/49] tests/tcg/arm: fix up test-arm-iwmmxt test Alex Bennée
2018-05-17 20:15   ` Richard Henderson
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 29/49] tests/tcg/arm: disable -p 32768 mmap test Alex Bennée
2018-05-17 20:20   ` Richard Henderson
2018-05-17 21:24     ` Alex Bennée
2018-05-17 21:34       ` Richard Henderson
2018-05-18  3:47         ` Philippe Mathieu-Daudé
2018-05-17 17:46 ` [Qemu-devel] [PATCH v4 30/49] tests/tcg: enable building for AArch64 Alex Bennée
2018-05-17 20:26   ` Richard Henderson
2018-05-18 14:57   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 31/49] tests/tcg/aarch64: add Makefile.target Alex Bennée
2018-05-17 20:28   ` Richard Henderson
2018-05-17 21:25     ` Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 32/49] tests/tcg/arm: add fcvt test cases for AArch32/64 Alex Bennée
2018-05-17 20:30   ` Richard Henderson
2018-05-18  3:45     ` Philippe Mathieu-Daudé
2018-05-18  8:16       ` Alex Bennée
2018-05-18 14:53         ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 33/49] tests/tcg: move MIPS specific tests into subdir Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 34/49] tests/tcg: enable building for MIPS Alex Bennée
2018-05-18 14:49   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 35/49] tests/tcg/mips: include common mips hello-mips Alex Bennée
2018-05-18 14:49   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 36/49] tests/tcg: enable building for s390x Alex Bennée
2018-05-18 12:04   ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 37/49] tests/tcg: enable building for ppc64 Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 38/49] tests/tcg: enable building for Alpha Alex Bennée
2018-05-18 14:21   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` Alex Bennée [this message]
2018-05-17 20:41   ` [Qemu-devel] [PATCH v4 39/49] tests/tcg/alpha: add Alpha specific tests Richard Henderson
2018-05-18 14:25   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 40/49] tests/tcg: enable building for HPPA Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 41/49] tests/tcg: enable building for m68k Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 42/49] tests/tcg: enable building for sh4 Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 43/49] tests/tcg: enable building for sparc64 Alex Bennée
2018-05-18 14:28   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 44/49] tests/tcg: enable building for mips64 Alex Bennée
2018-05-18 14:26   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 45/49] tests/tcg: enable building for RISCV64 Alex Bennée
2018-05-18 14:24   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 46/49] tests/tcg/Makefile: update to be called from Makefile.target Alex Bennée
2018-05-17 20:43   ` Richard Henderson
2018-05-18 14:49   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 47/49] Makefile.target: add (clean-/build-)guest-tests targets Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 48/49] tests/Makefile.include: add [build|clean|check]-tcg targets Alex Bennée
2018-05-17 17:47 ` [Qemu-devel] [PATCH v4 49/49] tests/tcg: override runners for broken tests (!UPSTREAM) Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180517174718.10107-40-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=balrogg@gmail.com \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).