From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJZR2-0008Tn-Rs for qemu-devel@nongnu.org; Fri, 18 May 2018 03:04:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJZQz-0001iN-Kr for qemu-devel@nongnu.org; Fri, 18 May 2018 03:04:16 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:34876 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fJZQz-0001iD-H9 for qemu-devel@nongnu.org; Fri, 18 May 2018 03:04:13 -0400 Date: Fri, 18 May 2018 09:04:12 +0200 From: Gerd Hoffmann Message-ID: <20180518070412.4zlrltobjqc54g6b@sirius.home.kraxel.org> References: <20180515185814.1374-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180515185814.1374-1-peter.maydell@linaro.org> Subject: Re: [Qemu-devel] [PATCH] sdl: Move use of surface pointer below check for whether it is NULL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org, Anatoly Trosinenko On Tue, May 15, 2018 at 07:58:14PM +0100, Peter Maydell wrote: > In commit 2ab858c6c38ee1 we added a use of the 'surf' variable > in sdl2_2d_update() that was unfortunately placed above the > early-exit-if-NULL check. Move it to where it ought to be. Added to ui patch queue. thanks, Gerd