From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
peterx@redhat.com, Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PATCH v2 1/2] qemu-error: introduce {error|warn}_report_once
Date: Tue, 22 May 2018 11:56:28 +0800 [thread overview]
Message-ID: <20180522035629.30428-2-peterx@redhat.com> (raw)
In-Reply-To: <20180522035629.30428-1-peterx@redhat.com>
I stole the printk_once() macro.
I always wanted to be able to print some error directly if there is a
buffer to dump, however we can't use error_report() where the code path
can be triggered by DDOS attack. To avoid that, we can introduce a
print-once-like function for it. Meanwhile, we also introduce the
corresponding helper for warn_report().
CC: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
include/qemu/error-report.h | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h
index e1c8ae1a52..3e6e84801f 100644
--- a/include/qemu/error-report.h
+++ b/include/qemu/error-report.h
@@ -44,6 +44,32 @@ void error_report(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
void warn_report(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
void info_report(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
+/* Similar to error_report(), but it only prints the message once. */
+#define error_report_once(fmt, ...) \
+ ({ \
+ static bool __print_once; \
+ bool __ret_print_once = !__print_once; \
+ \
+ if (!__print_once) { \
+ __print_once = true; \
+ error_report(fmt, ##__VA_ARGS__); \
+ } \
+ unlikely(__ret_print_once); \
+ })
+
+/* Similar to warn_report(), but it only prints the message once. */
+#define warn_report_once(fmt, ...) \
+ ({ \
+ static bool __print_once; \
+ bool __ret_print_once = !__print_once; \
+ \
+ if (!__print_once) { \
+ __print_once = true; \
+ warn_report(fmt, ##__VA_ARGS__); \
+ } \
+ unlikely(__ret_print_once); \
+ })
+
const char *error_get_progname(void);
extern bool enable_timestamp_msg;
--
2.17.0
next prev parent reply other threads:[~2018-05-22 3:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 3:56 [Qemu-devel] [PATCH v2 0/2] error-report: introduce {error|warn}_report_once Peter Xu
2018-05-22 3:56 ` Peter Xu [this message]
2018-05-23 15:47 ` [Qemu-devel] [PATCH v2 1/2] qemu-error: " Eric Blake
2018-05-24 2:56 ` Peter Xu
2018-05-22 3:56 ` [Qemu-devel] [PATCH v2 2/2] intel-iommu: start to use error_report_once Peter Xu
2018-05-22 21:09 ` Philippe Mathieu-Daudé
2018-05-23 1:19 ` Peter Xu
2018-05-24 3:40 ` Philippe Mathieu-Daudé
2018-05-22 5:08 ` [Qemu-devel] [PATCH v2 0/2] error-report: introduce {error|warn}_report_once Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522035629.30428-2-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).