From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/4] vga: move bochs vbe defines to header file
Date: Tue, 22 May 2018 11:24:26 +0200 [thread overview]
Message-ID: <20180522092425.va3aobj53adkv3i5@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAJ+F1C+Gq9QDBLQiuFDJ3c8gdV3kLhk_mGD8DOfkdhB2+3ic=Q@mail.gmail.com>
> > --- /dev/null
> > +++ b/include/hw/display/bochs-vbe.h
> > @@ -0,0 +1,64 @@
>
> No header guards & copyright notice?
Header guards ok.
Copyright?
I don't think interface #defines like this are copyrightable ...
cheers,
Gerd
next prev parent reply other threads:[~2018-05-22 9:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 9:25 [Qemu-devel] [PATCH 0/4] display: add new bochs-display device Gerd Hoffmann
2018-05-17 9:25 ` [Qemu-devel] [PATCH 1/4] vga: move bochs vbe defines to header file Gerd Hoffmann
2018-05-17 15:20 ` Philippe Mathieu-Daudé
2018-05-18 8:12 ` Gerd Hoffmann
2018-05-18 13:12 ` Marc-André Lureau
2018-05-22 9:24 ` Gerd Hoffmann [this message]
2018-05-17 9:25 ` [Qemu-devel] [PATCH 2/4] display: add new bochs-display device Gerd Hoffmann
2018-05-18 15:01 ` Marc-André Lureau
2018-05-17 9:25 ` [Qemu-devel] [PATCH 3/4] bochs-display: add dirty tracking support Gerd Hoffmann
2018-05-18 15:10 ` Marc-André Lureau
2018-05-17 9:25 ` [Qemu-devel] [PATCH 4/4] bochs-display: add pcie support Gerd Hoffmann
2018-05-18 15:13 ` Marc-André Lureau
2018-05-22 9:33 ` Gerd Hoffmann
2018-05-17 9:32 ` [Qemu-devel] [PATCH 0/4] display: add new bochs-display device no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522092425.va3aobj53adkv3i5@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).