qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, jcody@redhat.com, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] sheepdog: cleanup repeated expression
Date: Wed, 23 May 2018 10:12:35 +0800	[thread overview]
Message-ID: <20180523021235.GA31322@lemon.usersys.redhat.com> (raw)
In-Reply-To: <20180522201056.1442-2-pbonzini@redhat.com>

On Tue, 05/22 22:10, Paolo Bonzini wrote:
> The expression "SD_INODE_SIZE - sizeof(inode.data_vdi_id)" already has a macro
> defined for the same value (though with a nicer definition using offsetof).
> Replace it.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Fam Zheng <famz@redhat.com>

  parent reply	other threads:[~2018-05-23  2:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 20:10 [Qemu-devel] [PATCH 0/2] sheepdog: remove huge BSS object Paolo Bonzini
2018-05-22 20:10 ` [Qemu-devel] [PATCH 1/2] sheepdog: cleanup repeated expression Paolo Bonzini
2018-05-22 20:25   ` Philippe Mathieu-Daudé
2018-05-23  2:12   ` Fam Zheng [this message]
2018-05-23 15:30   ` Jeff Cody
2018-05-22 20:10 ` [Qemu-devel] [PATCH 2/2] sheepdog: remove huge BSS object Paolo Bonzini
2018-05-22 20:26   ` Philippe Mathieu-Daudé
2018-05-23  1:43   ` Fam Zheng
2018-05-23 17:25     ` Philippe Mathieu-Daudé
  -- strict thread matches above, loose matches on Subject: below --
2018-05-23 16:07 [Qemu-devel] [PATCH v2 0/2] " Paolo Bonzini
2018-05-23 16:07 ` [Qemu-devel] [PATCH 1/2] sheepdog: cleanup repeated expression Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180523021235.GA31322@lemon.usersys.redhat.com \
    --to=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).