qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, war2jordan@live.com,
	crosthwaite.peter@gmail.com, boost.lists@gmail.com,
	quintela@redhat.com, ciro.santilli@gmail.com,
	jasowang@redhat.com, mst@redhat.com, zuban32s@gmail.com,
	armbru@redhat.com, maria.klimushenkova@ispras.ru,
	dovgaluk@ispras.ru, kraxel@redhat.com, pavel.dovgaluk@ispras.ru,
	thomas.dullien@googlemail.com, pbonzini@redhat.com,
	mreitz@redhat.com, alex.bennee@linaro.org, dgilbert@redhat.com,
	rth@twiddle.net
Subject: [Qemu-devel] [PATCH v3 05/19] replay: finish record/replay before closing the disks
Date: Wed, 23 May 2018 09:50:11 +0300	[thread overview]
Message-ID: <20180523065010.26016.12340.stgit@pasha-VirtualBox> (raw)
In-Reply-To: <20180523064941.26016.74274.stgit@pasha-VirtualBox>

After recent updates block devices cannot be closed on qemu exit.
This happens due to the block request polling when replay is not finished.
Therefore now we stop execution recording before closing the block devices.

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
 replay/replay.c |    2 ++
 vl.c            |    1 +
 2 files changed, 3 insertions(+)

diff --git a/replay/replay.c b/replay/replay.c
index 8228261..58a986f 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -366,6 +366,8 @@ void replay_finish(void)
     g_free(replay_snapshot);
     replay_snapshot = NULL;
 
+    replay_mode = REPLAY_MODE_NONE;
+
     replay_finish_events();
 }
 
diff --git a/vl.c b/vl.c
index 0c963f7..ac2394a 100644
--- a/vl.c
+++ b/vl.c
@@ -4688,6 +4688,7 @@ int main(int argc, char **argv, char **envp)
 
     /* No more vcpu or device emulation activity beyond this point */
     vm_shutdown();
+    replay_finish();
 
     bdrv_close_all();
 

  parent reply	other threads:[~2018-05-23  6:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23  6:49 [Qemu-devel] [PATCH v3 00/19] reverse debugging Pavel Dovgalyuk
2018-05-23  6:49 ` [Qemu-devel] [PATCH v3 01/19] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2018-05-23  6:49 ` [Qemu-devel] [PATCH v3 02/19] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2018-05-23  6:49 ` [Qemu-devel] [PATCH v3 03/19] replay: update docs for record/replay with block devices Pavel Dovgalyuk
2018-05-23  6:50 ` [Qemu-devel] [PATCH v3 04/19] replay: don't drain/flush bdrv queue while RR is working Pavel Dovgalyuk
2018-05-23  6:50 ` Pavel Dovgalyuk [this message]
2018-05-23  6:50 ` [Qemu-devel] [PATCH v3 06/19] qcow2: introduce icount field for snapshots Pavel Dovgalyuk
2018-05-23  6:50 ` [Qemu-devel] [PATCH v3 07/19] migration: " Pavel Dovgalyuk
2018-05-23 18:08   ` Eric Blake
2018-05-23  6:50 ` [Qemu-devel] [PATCH v3 08/19] replay: introduce info hmp/qmp command Pavel Dovgalyuk
2018-05-23  6:50 ` [Qemu-devel] [PATCH v3 09/19] replay: introduce breakpoint at the specified step Pavel Dovgalyuk
2018-05-23  6:50 ` [Qemu-devel] [PATCH v3 10/19] replay: implement replay-seek command to proceed to the desired step Pavel Dovgalyuk
2018-05-23  6:50 ` [Qemu-devel] [PATCH v3 11/19] replay: flush events when exiting Pavel Dovgalyuk
2018-05-23  6:50 ` [Qemu-devel] [PATCH v3 12/19] timer: remove replay clock probe in deadline calculation Pavel Dovgalyuk
2018-05-23  6:50 ` [Qemu-devel] [PATCH v3 13/19] replay: refine replay-time module Pavel Dovgalyuk
2018-05-23  6:51 ` [Qemu-devel] [PATCH v3 14/19] translator: fix breakpoint processing Pavel Dovgalyuk
2018-05-23  6:51 ` [Qemu-devel] [PATCH v3 15/19] replay: flush rr queue before loading the vmstate Pavel Dovgalyuk
2018-05-23  6:51 ` [Qemu-devel] [PATCH v3 16/19] gdbstub: add reverse step support in replay mode Pavel Dovgalyuk
2018-05-23  6:51 ` [Qemu-devel] [PATCH v3 17/19] gdbstub: add reverse continue " Pavel Dovgalyuk
2018-05-23  6:51 ` [Qemu-devel] [PATCH v3 18/19] replay: describe reverse debugging in docs/replay.txt Pavel Dovgalyuk
2018-05-23  6:51 ` [Qemu-devel] [PATCH v3 19/19] replay: allow loading any snapshots before recording Pavel Dovgalyuk
2018-05-23 13:23 ` [Qemu-devel] [PATCH v3 00/19] reverse debugging Ciro Santilli
2018-05-23 13:28   ` Pavel Dovgalyuk
2018-05-23 15:57     ` Ciro Santilli
2018-05-24  6:00       ` Pavel Dovgalyuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180523065010.26016.12340.stgit@pasha-VirtualBox \
    --to=pavel.dovgaluk@ispras.ru \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=boost.lists@gmail.com \
    --cc=ciro.santilli@gmail.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=dovgaluk@ispras.ru \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=maria.klimushenkova@ispras.ru \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=rth@twiddle.net \
    --cc=thomas.dullien@googlemail.com \
    --cc=war2jordan@live.com \
    --cc=zuban32s@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).