qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH 0/2] qemu-iotests: Add more tests to "migration" group
@ 2018-05-23  9:58 Kevin Wolf
  2018-05-23  9:58 ` [Qemu-devel] [PATCH 1/2] " Kevin Wolf
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Kevin Wolf @ 2018-05-23  9:58 UTC (permalink / raw)
  To: qemu-block; +Cc: kwolf, quintela, qemu-devel

Kevin Wolf (2):
  qemu-iotests: Add more tests to "migration" group
  qemu-iotests: Remove MIG_SOCKET from non-migration tests

 tests/qemu-iotests/185   |  2 --
 tests/qemu-iotests/191   |  2 --
 tests/qemu-iotests/group | 10 +++++-----
 3 files changed, 5 insertions(+), 9 deletions(-)

-- 
2.13.6

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Qemu-devel] [PATCH 1/2] qemu-iotests: Add more tests to "migration" group
  2018-05-23  9:58 [Qemu-devel] [PATCH 0/2] qemu-iotests: Add more tests to "migration" group Kevin Wolf
@ 2018-05-23  9:58 ` Kevin Wolf
  2018-05-23 10:23   ` Juan Quintela
  2018-05-23  9:58 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: Remove MIG_SOCKET from non-migration tests Kevin Wolf
  2018-05-23 12:31 ` [Qemu-devel] [PATCH 0/2] qemu-iotests: Add more tests to "migration" group Kevin Wolf
  2 siblings, 1 reply; 6+ messages in thread
From: Kevin Wolf @ 2018-05-23  9:58 UTC (permalink / raw)
  To: qemu-block; +Cc: kwolf, quintela, qemu-devel

grep for "migrate" turns up a few test cases which use migration, but
haven't been in the "migration" group so far. Add them to the group.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 tests/qemu-iotests/group | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
index cc8cd8cc8e..60ba31b292 100644
--- a/tests/qemu-iotests/group
+++ b/tests/qemu-iotests/group
@@ -97,7 +97,7 @@
 088 rw auto quick
 089 rw auto quick
 090 rw auto quick
-091 rw auto
+091 rw auto migration
 092 rw auto quick
 093 auto
 094 rw auto quick
@@ -169,7 +169,7 @@
 162 auto quick
 163 rw auto
 165 rw auto quick
-169 rw auto quick
+169 rw auto quick migration
 170 rw auto quick
 171 rw auto quick
 172 auto
@@ -194,14 +194,14 @@
 192 rw auto quick
 194 rw auto migration quick
 195 rw auto quick
-196 rw auto quick
+196 rw auto quick migration
 197 rw auto quick
 198 rw auto
-199 rw auto
+199 rw auto migration
 200 rw auto
 201 rw auto migration
 202 rw auto quick
-203 rw auto
+203 rw auto migration
 204 rw auto quick
 205 rw auto quick
 206 rw auto
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Qemu-devel] [PATCH 2/2] qemu-iotests: Remove MIG_SOCKET from non-migration tests
  2018-05-23  9:58 [Qemu-devel] [PATCH 0/2] qemu-iotests: Add more tests to "migration" group Kevin Wolf
  2018-05-23  9:58 ` [Qemu-devel] [PATCH 1/2] " Kevin Wolf
@ 2018-05-23  9:58 ` Kevin Wolf
  2018-05-23 10:25   ` Juan Quintela
  2018-05-23 12:31 ` [Qemu-devel] [PATCH 0/2] qemu-iotests: Add more tests to "migration" group Kevin Wolf
  2 siblings, 1 reply; 6+ messages in thread
From: Kevin Wolf @ 2018-05-23  9:58 UTC (permalink / raw)
  To: qemu-block; +Cc: kwolf, quintela, qemu-devel

185 and 191 define a MIG_SOCKET even though they don't do anything with
migration. Remove the useless variable.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 tests/qemu-iotests/185 | 2 --
 tests/qemu-iotests/191 | 2 --
 2 files changed, 4 deletions(-)

diff --git a/tests/qemu-iotests/185 b/tests/qemu-iotests/185
index 9a2d317414..deb42cc886 100755
--- a/tests/qemu-iotests/185
+++ b/tests/qemu-iotests/185
@@ -27,8 +27,6 @@ echo "QA output created by $seq"
 here=`pwd`
 status=1 # failure is the default!
 
-MIG_SOCKET="${TEST_DIR}/migrate"
-
 _cleanup()
 {
     rm -f "${TEST_IMG}.mid"
diff --git a/tests/qemu-iotests/191 b/tests/qemu-iotests/191
index dfad6555e4..77224eb151 100755
--- a/tests/qemu-iotests/191
+++ b/tests/qemu-iotests/191
@@ -27,8 +27,6 @@ echo "QA output created by $seq"
 here=`pwd`
 status=1 # failure is the default!
 
-MIG_SOCKET="${TEST_DIR}/migrate"
-
 _cleanup()
 {
     rm -f "${TEST_IMG}.mid"
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: Add more tests to "migration" group
  2018-05-23  9:58 ` [Qemu-devel] [PATCH 1/2] " Kevin Wolf
@ 2018-05-23 10:23   ` Juan Quintela
  0 siblings, 0 replies; 6+ messages in thread
From: Juan Quintela @ 2018-05-23 10:23 UTC (permalink / raw)
  To: Kevin Wolf; +Cc: qemu-block, qemu-devel

Kevin Wolf <kwolf@redhat.com> wrote:
> grep for "migrate" turns up a few test cases which use migration, but
> haven't been in the "migration" group so far. Add them to the group.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

Thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Remove MIG_SOCKET from non-migration tests
  2018-05-23  9:58 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: Remove MIG_SOCKET from non-migration tests Kevin Wolf
@ 2018-05-23 10:25   ` Juan Quintela
  0 siblings, 0 replies; 6+ messages in thread
From: Juan Quintela @ 2018-05-23 10:25 UTC (permalink / raw)
  To: Kevin Wolf; +Cc: qemu-block, qemu-devel

Kevin Wolf <kwolf@redhat.com> wrote:
> 185 and 191 define a MIG_SOCKET even though they don't do anything with
> migration. Remove the useless variable.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH 0/2] qemu-iotests: Add more tests to "migration" group
  2018-05-23  9:58 [Qemu-devel] [PATCH 0/2] qemu-iotests: Add more tests to "migration" group Kevin Wolf
  2018-05-23  9:58 ` [Qemu-devel] [PATCH 1/2] " Kevin Wolf
  2018-05-23  9:58 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: Remove MIG_SOCKET from non-migration tests Kevin Wolf
@ 2018-05-23 12:31 ` Kevin Wolf
  2 siblings, 0 replies; 6+ messages in thread
From: Kevin Wolf @ 2018-05-23 12:31 UTC (permalink / raw)
  To: qemu-block; +Cc: quintela, qemu-devel

Am 23.05.2018 um 11:58 hat Kevin Wolf geschrieben:
> Kevin Wolf (2):
>   qemu-iotests: Add more tests to "migration" group
>   qemu-iotests: Remove MIG_SOCKET from non-migration tests

Applied to the block branch.

Kevin

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-05-23 12:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-23  9:58 [Qemu-devel] [PATCH 0/2] qemu-iotests: Add more tests to "migration" group Kevin Wolf
2018-05-23  9:58 ` [Qemu-devel] [PATCH 1/2] " Kevin Wolf
2018-05-23 10:23   ` Juan Quintela
2018-05-23  9:58 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: Remove MIG_SOCKET from non-migration tests Kevin Wolf
2018-05-23 10:25   ` Juan Quintela
2018-05-23 12:31 ` [Qemu-devel] [PATCH 0/2] qemu-iotests: Add more tests to "migration" group Kevin Wolf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).