From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLQxL-0007yZ-I6 for qemu-devel@nongnu.org; Wed, 23 May 2018 06:25:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLQxJ-0003t9-Io for qemu-devel@nongnu.org; Wed, 23 May 2018 06:25:19 -0400 From: Vladimir Sementsov-Ogievskiy Date: Wed, 23 May 2018 13:24:15 +0300 Message-Id: <20180523102419.28665-2-vsementsov@virtuozzo.com> In-Reply-To: <20180523102419.28665-1-vsementsov@virtuozzo.com> References: <20180523102419.28665-1-vsementsov@virtuozzo.com> Subject: [Qemu-devel] [PATCH v3 1/5] nbd/server: fix trace List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: armbru@redhat.com, pbonzini@redhat.com, eblake@redhat.com, mreitz@redhat.com, kwolf@redhat.com, vsementsov@virtuozzo.com, den@openvz.org Return code = 1 doesn't mean that we parsed base:allocation. Move trace point to appropriate place. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index 9e1f227178..7584ff7dcc 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -741,7 +741,10 @@ static int nbd_negotiate_send_meta_context(NBDClient *client, * the current name, after the 'base:' portion has been stripped. * * Return -errno on I/O error, 0 if option was completely handled by - * sending a reply about inconsistent lengths, or 1 on success. */ + * sending a reply about inconsistent lengths, or 1 on success. + * + * Note: return code = 1 doesn't mean that we've parsed "base:allocation" + * namespace. It only means that there are no errors.*/ static int nbd_meta_base_query(NBDClient *client, NBDExportMetaContexts *meta, uint32_t len, Error **errp) { @@ -768,10 +771,10 @@ static int nbd_meta_base_query(NBDClient *client, NBDExportMetaContexts *meta, } if (strncmp(query, "allocation", alen) == 0) { + trace_nbd_negotiate_meta_query_parse("base:allocation"); meta->base_allocation = true; } - trace_nbd_negotiate_meta_query_parse("base:allocation"); return 1; } -- 2.11.1