From: Peter Xu <peterx@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Tian Kevin <kevin.tian@intel.com>,
QEMU Stable <qemu-stable@nongnu.org>,
Jintack Lim <jintack@cs.columbia.edu>,
Jason Wang <jasowang@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 9/9] intel-iommu: rework the page walk logic
Date: Thu, 24 May 2018 10:54:19 +0800 [thread overview]
Message-ID: <20180524025419.GB756@xz-mi> (raw)
In-Reply-To: <20180523173227-mutt-send-email-mst@kernel.org>
On Wed, May 23, 2018 at 05:33:34PM +0300, Michael S. Tsirkin wrote:
> On Fri, May 18, 2018 at 03:25:17PM +0800, Peter Xu wrote:
> > SECURITY IMPLICATION: this patch will fix a potential small window that
> > the DMA page table might be incomplete or invalid when the guest sends
> > domain/context invalidations to a device. It can cause random DMA
> > errors for assigned devices.
>
> So this is more a correctness IMO. I don't see how can
> e.g. an application within guest cause any mischief
> with this, it will just get a non working device.
Yes, you are right. It causes valid mappings missing so there's no
risk to anyone but only unfunction. I should remove the "SECURITY
IMPLICATION" wordings.
Thanks,
--
Peter Xu
prev parent reply other threads:[~2018-05-24 2:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 7:25 [Qemu-devel] [PATCH v4 0/9] intel-iommu: nested vIOMMU, cleanups, bug fixes Peter Xu
2018-05-18 7:25 ` [Qemu-devel] [PATCH v4 1/9] intel-iommu: send PSI always even if across PDEs Peter Xu
2018-05-18 7:25 ` [Qemu-devel] [PATCH v4 2/9] intel-iommu: remove IntelIOMMUNotifierNode Peter Xu
2018-05-18 7:25 ` [Qemu-devel] [PATCH v4 3/9] intel-iommu: add iommu lock Peter Xu
2018-05-18 7:25 ` [Qemu-devel] [PATCH v4 4/9] intel-iommu: only do page walk for MAP notifiers Peter Xu
2018-05-18 7:25 ` [Qemu-devel] [PATCH v4 5/9] intel-iommu: introduce vtd_page_walk_info Peter Xu
2018-05-18 7:25 ` [Qemu-devel] [PATCH v4 6/9] intel-iommu: pass in address space when page walk Peter Xu
2018-05-18 7:25 ` [Qemu-devel] [PATCH v4 7/9] intel-iommu: trace domain id during " Peter Xu
2018-05-18 7:25 ` [Qemu-devel] [PATCH v4 8/9] util: implement simple iova tree Peter Xu
2018-05-18 7:25 ` [Qemu-devel] [PATCH v4 9/9] intel-iommu: rework the page walk logic Peter Xu
2018-05-23 14:33 ` Michael S. Tsirkin
2018-05-24 2:54 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524025419.GB756@xz-mi \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jasowang@redhat.com \
--cc=jintack@cs.columbia.edu \
--cc=kevin.tian@intel.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).