From: Peter Xu <peterx@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, "Eric Blake" <eblake@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs
Date: Thu, 24 May 2018 16:49:23 +0800 [thread overview]
Message-ID: <20180524084923.GG12122@xz-mi> (raw)
In-Reply-To: <20180524080804.GC20733@stefanha-x1.localdomain>
On Thu, May 24, 2018 at 09:08:04AM +0100, Stefan Hajnoczi wrote:
> On Thu, May 24, 2018 at 12:39:51PM +0800, Peter Xu wrote:
> > Add some explicit comment for both Readline and cpu_set/cpu_get helpers
> > that they do not need the mon_lock protection.
> >
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> > monitor.c | 12 +++++++++++-
> > 1 file changed, 11 insertions(+), 1 deletion(-)
>
> Aside from the checkpatch.pl error that needs to be fixed (I like to use
> a git hook to check automatically, see
> http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html):
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Thanks Stefan. I start to use it now!
--
Peter Xu
next prev parent reply other threads:[~2018-05-24 8:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 4:39 [Qemu-devel] [PATCH v7 0/4] monitor: let Monitor be thread safe Peter Xu
2018-05-24 4:39 ` [Qemu-devel] [PATCH v7 1/4] monitor: rename out_lock to mon_lock Peter Xu
2018-05-24 8:29 ` Markus Armbruster
2018-05-24 8:45 ` Peter Xu
2018-05-24 11:14 ` Markus Armbruster
2018-05-24 4:39 ` [Qemu-devel] [PATCH v7 2/4] monitor: protect mon->fds with mon_lock Peter Xu
2018-05-24 4:39 ` [Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs Peter Xu
2018-05-24 8:08 ` Stefan Hajnoczi
2018-05-24 8:49 ` Peter Xu [this message]
2018-05-24 8:41 ` Markus Armbruster
2018-05-24 8:48 ` Peter Xu
2018-05-24 11:16 ` Markus Armbruster
2018-05-28 6:28 ` Peter Xu
2018-05-24 4:39 ` [Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets Peter Xu
2018-05-24 9:03 ` Markus Armbruster
2018-05-28 7:06 ` Peter Xu
2018-05-28 15:19 ` Markus Armbruster
2018-05-29 5:51 ` Peter Xu
2018-05-24 9:28 ` Stefan Hajnoczi
2018-05-25 3:30 ` Peter Xu
2018-05-25 9:01 ` Stefan Hajnoczi
2018-05-28 6:29 ` Peter Xu
2018-05-24 4:46 ` [Qemu-devel] [PATCH v7 0/4] monitor: let Monitor be thread safe no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524084923.GG12122@xz-mi \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).