From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLrj0-00087h-EZ for qemu-devel@nongnu.org; Thu, 24 May 2018 11:00:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLriv-0005Ar-ID for qemu-devel@nongnu.org; Thu, 24 May 2018 11:00:18 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:52782 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fLriv-0005Aa-Dx for qemu-devel@nongnu.org; Thu, 24 May 2018 11:00:13 -0400 Date: Thu, 24 May 2018 18:00:12 +0300 From: "Michael S. Tsirkin" Message-ID: <20180524175709-mutt-send-email-mst@kernel.org> References: <1527172175-129517-1-git-send-email-mst@redhat.com> <6b3cad0d-b849-6ba9-64cb-6a36a37cd19d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b3cad0d-b849-6ba9-64cb-6a36a37cd19d@redhat.com> Subject: Re: [Qemu-devel] [PATCH] libqtest: fail if child coredumps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, Eric Blake , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Markus Armbruster , Tiwei Bie On Thu, May 24, 2018 at 04:45:31PM +0200, Thomas Huth wrote: > On 24.05.2018 16:30, Michael S. Tsirkin wrote: > > Right now tests report OK status if QEMU crashes during cleanup. > > Let's catch that case and fail the test. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > tests/libqtest.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/tests/libqtest.c b/tests/libqtest.c > > index 43fb97e..f869854 100644 > > --- a/tests/libqtest.c > > +++ b/tests/libqtest.c > > @@ -103,8 +103,15 @@ static int socket_accept(int sock) > > static void kill_qemu(QTestState *s) > > { > > if (s->qemu_pid != -1) { > > + int wstatus = 0; > > + pid_t pid; > > + > > kill(s->qemu_pid, SIGTERM); > > - waitpid(s->qemu_pid, NULL, 0); > > + pid = waitpid(s->qemu_pid, &wstatus, 0); > > + > > + if (pid == s->qemu_pid && WIFSIGNALED(wstatus)) { > > + assert(!WCOREDUMP(wstatus)); > > + } > > } > > } > > That's basically a good idea ... but I've already seen yet another issue > in the past already: QEMU sometimes simply hangs in an endless loop > during clean up and never terminates. I think we should detect that > situation, too. So instead of killing QEMU at the end of the testing, I think we should > rather try to terminate it with the QMP "quit" command. If QEMU does not > terminate with an exit code of 0, then the test should be flagged a > failed (and only if QEMU did not terminate at all, it should be killed > with SIGKILL). > > Thomas Fine but can we agree to do this as a patch on top? And do you have the time to implement this? I'm seeing patches that cause crash on cleanup, it's not a theoretical problem for me, so I'd like this one to go in first. -- MST