qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>,
	Laurent Vivier <laurent@vivier.eu>,
	Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PULL 03/13] linux-user: update comments to point to tcg_exec_init()
Date: Fri, 25 May 2018 10:17:44 +0200	[thread overview]
Message-ID: <20180525081754.29506-4-laurent@vivier.eu> (raw)
In-Reply-To: <20180525081754.29506-1-laurent@vivier.eu>

From: Igor Mammedov <imammedo@redhat.com>

cpu_init() was replaced by cpu_create() since 2.12 but comments
weren't updated. So update stale comments to point that page
sizes arei actually initialized by tcg_exec_init(). Also move
another qemu_host_page_size related comment before tcg_exec_init()
where it belongs.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <1526557877-293151-1-git-send-email-imammedo@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 bsd-user/main.c   | 7 ++++---
 linux-user/main.c | 5 ++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/bsd-user/main.c b/bsd-user/main.c
index 283dc6fd25..da3b833975 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -898,9 +898,10 @@ int main(int argc, char **argv)
         cpu_model = "any";
 #endif
     }
+
+    /* init tcg before creating CPUs and to get qemu_host_page_size */
     tcg_exec_init(0);
-    /* NOTE: we need to init the CPU at this stage to get
-       qemu_host_page_size */
+
     cpu_type = parse_cpu_model(cpu_model);
     cpu = cpu_create(cpu_type);
     env = cpu->env_ptr;
@@ -917,7 +918,7 @@ int main(int argc, char **argv)
     envlist_free(envlist);
 
     /*
-     * Now that page sizes are configured in cpu_init() we can do
+     * Now that page sizes are configured in tcg_exec_init() we can do
      * proper page alignment for guest_base.
      */
     guest_base = HOST_PAGE_ALIGN(guest_base);
diff --git a/linux-user/main.c b/linux-user/main.c
index 32347545c9..78d6d3e7eb 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -671,9 +671,8 @@ int main(int argc, char **argv, char **envp)
     }
     cpu_type = parse_cpu_model(cpu_model);
 
+    /* init tcg before creating CPUs and to get qemu_host_page_size */
     tcg_exec_init(0);
-    /* NOTE: we need to init the CPU at this stage to get
-       qemu_host_page_size */
 
     cpu = cpu_create(cpu_type);
     env = cpu->env_ptr;
@@ -693,7 +692,7 @@ int main(int argc, char **argv, char **envp)
     envlist_free(envlist);
 
     /*
-     * Now that page sizes are configured in cpu_init() we can do
+     * Now that page sizes are configured in tcg_exec_init() we can do
      * proper page alignment for guest_base.
      */
     guest_base = HOST_PAGE_ALIGN(guest_base);
-- 
2.14.3

  parent reply	other threads:[~2018-05-25  8:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-25  8:17 [Qemu-devel] [PULL 00/13] Linux user for 2.13 patches Laurent Vivier
2018-05-25  8:17 ` [Qemu-devel] [PULL 01/13] linux-user: Assert on bad type in thunk_type_align() and thunk_type_size() Laurent Vivier
2018-05-25  8:17 ` [Qemu-devel] [PULL 02/13] linux-user: update netlink emulation Laurent Vivier
2018-05-25  8:17 ` Laurent Vivier [this message]
2018-05-25  8:17 ` [Qemu-devel] [PULL 04/13] linux-user: Fix payload size logic in host_to_target_cmsg() Laurent Vivier
2018-05-25  8:17 ` [Qemu-devel] [PULL 05/13] linux-user: move mips socket.h definitions to mips/sockbits.h Laurent Vivier
2018-05-25  8:17 ` [Qemu-devel] [PULL 06/13] linux-user: move alpha socket.h definitions to alpha/sockbits.h Laurent Vivier
2018-05-25  8:17 ` [Qemu-devel] [PULL 07/13] linux-user: move sparc/sparc64 socket.h definitions to sparc/sockbits.h Laurent Vivier
2018-05-25  8:17 ` [Qemu-devel] [PULL 08/13] linux-user: move socket.h generic definitions to generic/sockbits.h Laurent Vivier
2018-05-25  8:17 ` [Qemu-devel] [PULL 09/13] linux-user: move ppc socket.h definitions to ppc/sockbits.h Laurent Vivier
2018-05-25  8:17 ` [Qemu-devel] [PULL 10/13] linux-user: update ARCH_HAS_SOCKET_TYPES use Laurent Vivier
2018-05-25  8:17 ` [Qemu-devel] [PULL 11/13] linux-user: copy sparc/sockbits.h definitions from linux Laurent Vivier
2018-05-25  8:17 ` [Qemu-devel] [PULL 12/13] linux-user: define TARGET_SO_REUSEPORT Laurent Vivier
2018-05-25  8:17 ` [Qemu-devel] [PULL 13/13] gdbstub: Clarify what gdb_handlesig() is doing Laurent Vivier
2018-05-25  8:32 ` [Qemu-devel] [PULL 00/13] Linux user for 2.13 patches no-reply
2018-05-25  9:54 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180525081754.29506-4-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).