From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org,
Stefan Hajnoczi <stefanha@redhat.com>,
Fam Zheng <famz@redhat.com>, Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 15/20] migration: use local path for local headers
Date: Fri, 25 May 2018 23:56:48 +0300 [thread overview]
Message-ID: <20180525235613-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <df745a8b-a48b-3e9a-f44f-ebff27111847@redhat.com>
On Fri, May 25, 2018 at 01:24:08PM -0500, Eric Blake wrote:
> On 05/25/2018 11:48 AM, Michael S. Tsirkin wrote:
> > When pulling in headers that are in the same directory as C file (as
>
> s/as C/as the C/ (here and in many other messages)
Will fix, thanks.
> > opposed to one in include/), we should use its relative path, without a
> > directory. Directory based path works more or less by accident.
>
> Missed trimming this out of your commit message.
Will fix, thanks.
> Or, if you want, on many of these commits, you could be more explicit about
> intention:
>
> When pulling in headers that are in the same directory as the C file (as
> opposed to one in include/), we prefer to use its relative path without a
> directory, rather than relying on the global -I$(SRC_DIR) that may be
> removed in a later patch.
I'm no longer sure we'll be able to.
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-05-25 20:56 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 16:47 [Qemu-devel] [PATCH v2 00/20] include cleanups Michael S. Tsirkin
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 01/20] block: use local path for local headers Michael S. Tsirkin
2018-05-25 18:25 ` Eric Blake
2018-05-25 21:41 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 02/20] crypto: " Michael S. Tsirkin
2018-05-25 21:40 ` Philippe Mathieu-Daudé
2018-06-01 12:22 ` Daniel P. Berrangé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 03/20] hppa: " Michael S. Tsirkin
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 04/20] migration: drop an unused include Michael S. Tsirkin
2018-05-25 18:27 ` Eric Blake
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 05/20] trace: use local path for local headers Michael S. Tsirkin
2018-05-25 21:29 ` Philippe Mathieu-Daudé
2018-05-25 21:49 ` Michael S. Tsirkin
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 06/20] display: " Michael S. Tsirkin
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 07/20] ide: " Michael S. Tsirkin
2018-05-25 21:39 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 08/20] ioapic: fix up includes Michael S. Tsirkin
2018-05-25 21:37 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 09/20] e1000e: use local path for local headers Michael S. Tsirkin
2018-05-25 21:36 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 10/20] rocker: drop an unused include Michael S. Tsirkin
2018-05-25 21:34 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 11/20] ppc: use local path for local headers Michael S. Tsirkin
2018-05-25 22:43 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 12/20] vhost-scsi: drop an unused include Michael S. Tsirkin
2018-05-26 4:29 ` Philippe Mathieu-Daudé
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 14/20] usb: use local path for local headers Michael S. Tsirkin
2018-05-25 21:35 ` Philippe Mathieu-Daudé
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 13/20] sd: fix up include Michael S. Tsirkin
2018-05-25 21:31 ` Philippe Mathieu-Daudé
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 15/20] migration: use local path for local headers Michael S. Tsirkin
2018-05-25 18:24 ` Eric Blake
2018-05-25 20:56 ` Michael S. Tsirkin [this message]
2018-05-25 18:27 ` Juan Quintela
2018-05-25 20:57 ` Michael S. Tsirkin
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 16/20] colo: " Michael S. Tsirkin
2018-05-26 4:31 ` Philippe Mathieu-Daudé
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 17/20] qga: " Michael S. Tsirkin
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 18/20] trace: " Michael S. Tsirkin
2018-05-25 21:32 ` Philippe Mathieu-Daudé
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 19/20] ui: " Michael S. Tsirkin
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 20/20] arch_init: sort architectures Michael S. Tsirkin
2018-05-28 11:13 ` Laszlo Ersek
2018-05-25 18:32 ` [Qemu-devel] [PATCH v2 00/20] include cleanups Eric Blake
2018-05-25 21:54 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525235613-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).