From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMJmf-0005M4-70 for qemu-devel@nongnu.org; Fri, 25 May 2018 16:57:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMJme-0007Wv-CB for qemu-devel@nongnu.org; Fri, 25 May 2018 16:57:57 -0400 Date: Fri, 25 May 2018 23:57:46 +0300 From: "Michael S. Tsirkin" Message-ID: <20180525235655-mutt-send-email-mst@kernel.org> References: <1527266793-301361-1-git-send-email-mst@redhat.com> <1527266793-301361-16-git-send-email-mst@redhat.com> <87vabb1thk.fsf@secure.laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87vabb1thk.fsf@secure.laptop> Subject: Re: [Qemu-devel] [PATCH v2 15/20] migration: use local path for local headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, eblake@redhat.com, peter.maydell@linaro.org, Stefan Hajnoczi , Fam Zheng , "Dr. David Alan Gilbert" , qemu-block@nongnu.org On Fri, May 25, 2018 at 08:27:03PM +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > When pulling in headers that are in the same directory as C file (as > > opposed to one in include/), we should use its relative path, without a > > directory. Directory based path works more or less by accident. > > I don't agree with the comment that they work by accident, Oh I removed this from most commit messages but somehow this one managed to sneek in. I agree, will drop this sentence. > it is > "by-design". But if you want to change the design, I agree with > removing "$ROOT" from the default include path. > > > > > Signed-off-by: Michael S. Tsirkin > > Reviewed-by: Juan Quintela > > Later, Juan. Thanks!