From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMKfC-0005EQ-Q6 for qemu-devel@nongnu.org; Fri, 25 May 2018 17:54:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMKf8-0002TM-Ix for qemu-devel@nongnu.org; Fri, 25 May 2018 17:54:18 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:39110 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fMKf8-0002T8-D1 for qemu-devel@nongnu.org; Fri, 25 May 2018 17:54:14 -0400 Date: Sat, 26 May 2018 00:54:13 +0300 From: "Michael S. Tsirkin" Message-ID: <20180526005318-mutt-send-email-mst@kernel.org> References: <1527266793-301361-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 00/20] include cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, Paolo Bonzini On Fri, May 25, 2018 at 01:32:40PM -0500, Eric Blake wrote: > On 05/25/2018 11:47 AM, Michael S. Tsirkin wrote: > > Right now, a local header can be included with either > > > > #include "foo.h" > > or > > #include "dir/foo.h" > > > > since the later doesn't tell you where the header is > > (in source or include directory), the former is preferable. > > > > I intend to look for ways to prevent the second way from working, but > > that will take time. For now, fix all instances for the later way I > > could find. > > > > In a couple of places I just dropped the include instead. > > > > Finally, arch_init huge list of includes is sorted, which will be > > helpful in future cleanups. > > > > This was part of the include path cleanup patchset > > (https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg00739.html). > > > > Changes from v1 > > drop patches not dealing with local headers > > stop saying include through root works by accident - > > it's not by accident, just not how we'd like code to look like > > You mostly did that, but I still think some of the commit messages can be > improved. See 15/20. > > > address comments by eric, philip, others > > At any rate, I think we are getting closer; and splitting this into a > less-controversial part compared to the rest of v1 makes it more likely that > this half can go in soon. Many of the patches are independent, but it's > still probably easier if this goes in through one tree (Paolo's misc tree, > perhaps?), once you've collected reviews. I plan to just merge these through my tree. > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org