From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Eric Blake" <eblake@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
peterx@redhat.com
Subject: [Qemu-devel] [PATCH v8 0/5] monitor: let Monitor be thread safe
Date: Mon, 28 May 2018 15:19:53 +0800 [thread overview]
Message-ID: <20180528071958.17053-1-peterx@redhat.com> (raw)
v8:
- some wording changes according to previous comments [Markus]
- return -ENOENT too in stubs/fdset.c:monitor_fdset_get_fd() [Stefan]
- refactor the fdset functions a bit, drop "ret" where proper [Markus]
- one more patch to fix monitor_lock comment [Markus]
- regular rebase and torturing
v7:
- let monitor_fdset_get_fd() return -errno, touch up qemu_open() to
translate that into errno. [Markus]
- touch up comment for Monitor.rs
- rebase, and torture the code a bit with qtest.
v6:
- add/drop some r-bs
- address all the comments from Markus
- rebase, and run some simple qtests to make sure nothing breaks
v5:
- collect r-bs and rebase
- move two close()s outside critical section [Dave]
- move comment to end of line [Stefan]
v4:
- fix a s/cur_mon/mon/ typo
v3:
- add comment for fields that are protected by monitor lock [Stefan]
- drop most of patch 2, only keep the protections for mon->fds [Stefan]
- add one trivial patch to add some more comments for either readline
and cpu_get/cpu_set [Stefan]
- add protection for monitor_fdset_get_fd() [Stefan]
v2:
- cc correct people... sorry.
Stefan reported this problem that in the future we might start to have
more threads operating on the same Monitor object. This seris try to
add fundamental support for it.
Please review. Thanks,
Peter Xu (5):
monitor: rename out_lock to mon_lock
monitor: protect mon->fds with mon_lock
monitor: more comments on lock-free elements
monitor: fix comment for monitor_lock
monitor: add lock to protect mon_fdsets
monitor.c | 152 ++++++++++++++++++++++++++++++++++++--------------
stubs/fdset.c | 2 +-
util/osdep.c | 3 +-
3 files changed, 113 insertions(+), 44 deletions(-)
--
2.17.0
next reply other threads:[~2018-05-28 7:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 7:19 Peter Xu [this message]
2018-05-28 7:19 ` [Qemu-devel] [PATCH v8 1/5] monitor: rename out_lock to mon_lock Peter Xu
2018-05-28 7:19 ` [Qemu-devel] [PATCH v8 2/5] monitor: protect mon->fds with mon_lock Peter Xu
2018-05-28 7:19 ` [Qemu-devel] [PATCH v8 3/5] monitor: more comments on lock-free elements Peter Xu
2018-05-28 7:19 ` [Qemu-devel] [PATCH v8 4/5] monitor: fix comment for monitor_lock Peter Xu
2018-05-28 7:19 ` [Qemu-devel] [PATCH v8 5/5] monitor: add lock to protect mon_fdsets Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528071958.17053-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).