From: linzhecheng <linzhecheng@huawei.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, wangxinxin.wang@huawei.com,
linzhecheng <linzhecheng@huawei.com>
Subject: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN
Date: Tue, 29 May 2018 10:52:40 +0800 [thread overview]
Message-ID: <20180529025240.520-1-linzhecheng@huawei.com> (raw)
Signed-off-by: linzhecheng <linzhecheng@huawei.com>
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index 159e69c3b1..17519ec589 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -134,8 +134,8 @@ static int tcp_chr_write(Chardev *chr, const uint8_t *buf, int len)
s->write_msgfds,
s->write_msgfds_num);
- /* free the written msgfds, no matter what */
- if (s->write_msgfds_num) {
+ /* free the written msgfds in any cases other than errno==EAGAIN */
+ if (EAGAIN != errno && s->write_msgfds_num) {
g_free(s->write_msgfds);
s->write_msgfds = 0;
s->write_msgfds_num = 0;
--
2.12.2.windows.2
next reply other threads:[~2018-05-29 2:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 2:52 linzhecheng [this message]
2018-05-29 9:11 ` [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN Marc-André Lureau
2018-05-30 2:56 ` Peter Xu
2018-06-01 11:46 ` Daniel P. Berrangé
-- strict thread matches above, loose matches on Subject: below --
2018-05-29 8:20 linzhecheng
2018-05-29 8:41 ` Gonglei (Arei)
2018-05-29 9:33 linzhecheng
2018-05-29 19:33 ` Eric Blake
2018-05-30 9:05 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529025240.520-1-linzhecheng@huawei.com \
--to=linzhecheng@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wangxinxin.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).