qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org, "Jason Wang" <jasowang@redhat.com>,
	"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Cédric Le Goater" <clg@kaod.org>
Subject: [Qemu-devel] [PATCH 3/6] net/ftgmac100: fix multicast hash routine
Date: Tue, 29 May 2018 08:28:35 +0200	[thread overview]
Message-ID: <20180529062838.20556-4-clg@kaod.org> (raw)
In-Reply-To: <20180529062838.20556-1-clg@kaod.org>

Based on the multicast hash calculation of the FTGMAC100 Linux driver.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/net/ftgmac100.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/net/ftgmac100.c b/hw/net/ftgmac100.c
index 50af1222464a..fd7699b1c05e 100644
--- a/hw/net/ftgmac100.c
+++ b/hw/net/ftgmac100.c
@@ -778,8 +778,8 @@ static int ftgmac100_filter(FTGMAC100State *s, const uint8_t *buf, size_t len)
                 return 0;
             }
 
-            /* TODO: this does not seem to work for ftgmac100 */
-            mcast_idx = net_crc32(buf, ETH_ALEN) >> 26;
+            mcast_idx = net_crc32_le(buf, ETH_ALEN);
+            mcast_idx = (~(mcast_idx >> 2)) & 0x3f;
             if (!(s->math[mcast_idx / 32] & (1 << (mcast_idx % 32)))) {
                 return 0;
             }
-- 
2.13.6

  parent reply	other threads:[~2018-05-29  6:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29  6:28 [Qemu-devel] [PATCH 0/6] ftgmac100 and NC-SI enhancements for the Aspeed SoC Cédric Le Goater
2018-05-29  6:28 ` [Qemu-devel] [PATCH 1/6] ftgmac100: compute maximum frame size depending on the protocol Cédric Le Goater
2018-05-29 13:29   ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2018-05-29  6:28 ` [Qemu-devel] [PATCH 2/6] ftgmac100: add IEEE 802.1Q VLAN support Cédric Le Goater
2018-05-29 13:34   ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2018-05-29 16:56     ` Cédric Le Goater
2018-05-30  3:03       ` Philippe Mathieu-Daudé
2018-05-29  6:28 ` Cédric Le Goater [this message]
2018-05-29 12:34   ` [Qemu-devel] [PATCH 3/6] net/ftgmac100: fix multicast hash routine Philippe Mathieu-Daudé
2018-05-29  6:28 ` [Qemu-devel] [PATCH 4/6] slirp/ncsi: fix "Get Version ID" payload length Cédric Le Goater
2018-05-29 12:42   ` Philippe Mathieu-Daudé
2018-05-29  6:28 ` [Qemu-devel] [PATCH 5/6] slirp/ncsi: add a "Get Parameter" response Cédric Le Goater
2018-05-29 13:11   ` Philippe Mathieu-Daudé
2018-05-29 17:12     ` Cédric Le Goater
2018-05-29  6:28 ` [Qemu-devel] [PATCH 6/6] slirp/ncsi: add checksum support Cédric Le Goater
2018-05-29 13:24   ` Philippe Mathieu-Daudé
2018-05-29 12:34 ` [Qemu-devel] [Qemu-arm] [PATCH 0/6] ftgmac100 and NC-SI enhancements for the Aspeed SoC Philippe Mathieu-Daudé
2018-05-29 16:57   ` Cédric Le Goater
2018-05-30  3:04     ` Philippe Mathieu-Daudé
2018-05-30  5:26       ` Cédric Le Goater
2018-05-30  5:35 ` [Qemu-devel] " Joel Stanley
2018-05-30  6:25   ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180529062838.20556-4-clg@kaod.org \
    --to=clg@kaod.org \
    --cc=jasowang@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).