Re: [Qemu-devel] [PATCH v4 01/21] vfio: Include "exec/address-spaces.h" directly in the source file

[Alex Williamson <alex.williamson@redhat.com>]

On Tue, 29 May 2018 12:45:28 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 29/05/2018 11:53, Cornelia Huck wrote:
> > On Mon, 28 May 2018 21:36:31 -0300
> > Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> >   
> >> On 05/28/2018 09:06 PM, Michael S. Tsirkin wrote:  
> >>> On Mon, May 28, 2018 at 05:48:05PM -0600, Alex Williamson wrote:    
> >>>> On Mon, 28 May 2018 20:26:59 -0300
> >>>> Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> >>>>
> >>>> -ENOCOMMITLOG    
> >>
> >> Oops sorry Alex, I meant to add some, but missed this while rebasing.
> >>  
> >>>> Why?  Tangible benefit.  Looks like noise.  Thanks,
> >>>>    
> >>> I agree it should have a commit log, but .c files
> >>> should be self-sufficient not rely on .h files
> >>> pulling in headers for symbols the .h does not use
> >>> itself.    
> >>
> >> I meant:
> >>
> >>   No declaration of "hw/vfio/vfio-common.h" directly requires to include
> >>   the "exec/address-spaces.h" header.  To simplify dependencies and
> >>   ease following cleanup of "exec/address-spaces.h", directly include
> >>   it in the source file where the declaration are used.
> >>  
> >>> This is better because it makes refactoring easier.
> >>>     
> >>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >>>>> ---
> >>>>>  include/hw/vfio/vfio-common.h | 1 -
> >>>>>  hw/vfio/ccw.c                 | 1 +
> >>>>>  hw/vfio/platform.c            | 1 +
> >>>>>  3 files changed, 2 insertions(+), 1 deletion(-)  
> > 
> > With the description added:
> > 
> > Acked-by: Cornelia Huck <cohuck@redhat.com>
> >   
> 
> Alex, is the description okay with you too?

Yes, if someone wants to roll this on on commit,

Acked-by: Alex Williamson <alex.williamson@redhat.com>