From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
qemu-block@nongnu.org, qemu-ppc@nongnu.org, qemu-arm@nongnu.org,
"John Snow" <jsnow@redhat.com>, "Kevin Wolf" <kwolf@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
"Alexander Graf" <agraf@suse.de>
Subject: [Qemu-devel] [PATCH 0/4] qapi/error: converts error_setg(&error_fatal) to error_report() + exit()
Date: Tue, 29 May 2018 14:48:17 -0300 [thread overview]
Message-ID: <20180529174821.19964-1-f4bug@amsat.org> (raw)
Hi,
This series converts error_setg(&error_fatal) to error_report() + exit() as
suggested by the "qapi/error.h" documentation.
This reduce Coverity and Clang static analyzer positive falses.
See http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg07585.html:
On 07/24/2017 04:52 PM, Eric Blake wrote:
That's a shame. Rather, we should patch this file (and others) to avoid
all the inconsistent uses of error_setg(&error_*), to comply with the
error.h documentation.
Regards,
Phil.
Philippe Mathieu-Daudé (4):
hw/block/fdc: Replace error_setg(&error_abort) by error_report() + abort()
hw/ppc/spapr_drc: Replace error_setg(&error_abort) by error_report() +
abort()
hw/arm/sysbus-fdt: Replace error_setg(&error_fatal) by error_report()
+ exit()
device_tree: Replace error_setg(&error_fatal) by error_report() + exit()
device_tree.c | 23 +++++++++++++----------
hw/arm/sysbus-fdt.c | 45 ++++++++++++++++++++++++++-------------------
hw/block/fdc.c | 7 ++++---
hw/ppc/spapr_drc.c | 3 ++-
4 files changed, 45 insertions(+), 33 deletions(-)
--
2.17.0
next reply other threads:[~2018-05-29 17:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 17:48 Philippe Mathieu-Daudé [this message]
2018-05-29 17:48 ` [Qemu-devel] [PATCH 1/4] hw/block/fdc: Replace error_setg(&error_abort) by error_report() + abort() Philippe Mathieu-Daudé
2018-05-30 20:23 ` John Snow
2018-05-30 21:30 ` Philippe Mathieu-Daudé
2018-06-07 13:41 ` Markus Armbruster
2018-06-07 14:27 ` Philippe Mathieu-Daudé
2018-05-29 17:48 ` [Qemu-devel] [PATCH 2/4] hw/ppc/spapr_drc: " Philippe Mathieu-Daudé
2018-06-04 1:25 ` David Gibson
2018-05-29 17:48 ` [Qemu-devel] [PATCH 3/4] hw/arm/sysbus-fdt: Replace error_setg(&error_fatal) by error_report() + exit() Philippe Mathieu-Daudé
2018-06-07 13:53 ` Markus Armbruster
2018-05-29 17:48 ` [Qemu-devel] [PATCH 4/4] device_tree: " Philippe Mathieu-Daudé
2018-06-07 13:50 ` Markus Armbruster
2018-05-29 19:38 ` [Qemu-devel] [PATCH 0/4] qapi/error: converts error_setg(&error_fatal) to " Auger Eric
2018-06-07 13:48 ` Markus Armbruster
2018-06-07 14:49 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529174821.19964-1-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).