qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, jcody@redhat.com,
	jsnow@redhat.com, eblake@redhat.com, pkrempa@redhat.com,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 00/16] block: Make blockdev-create a job and stable API
Date: Tue, 29 May 2018 22:38:54 +0200	[thread overview]
Message-ID: <20180529203910.7615-1-kwolf@redhat.com> (raw)

This changes the x-blockdev-create QMP command so that it doesn't block
the monitor and the main loop any more, but starts a background job that
performs the image creation.

The basic job as implemented here is all that is necessary to make image
creation asynchronous and to provide a QMP interface that can be marked
stable, but it still lacks a few features that jobs usually provide: The
job will ignore pause commands and it doesn't publish progress yet (so
both current-progress and total-progress stay at 0). These features can
be added later without breaking compatibility.

At the end of the series, the interface is declared stable and the x-
prefix is removed.

v2:
- Made job->error == NULL iff job->ret == 0 [Max]
- Fixed a comment in qmp_blockdev_create() and added a TODO comment for
  AioContext locking at least [Max]
- Many small changes in the tests [Max, Jeff]

Kevin Wolf (16):
  vdi: Fix vdi_co_do_create() return value
  vhdx: Fix vhdx_co_create() return value
  job: Add error message for failing jobs
  block/create: Make x-blockdev-create a job
  qemu-iotests: Add VM.get_qmp_events_filtered()
  qemu-iotests: Add VM.qmp_log()
  qemu-iotests: Add iotests.img_info_log()
  qemu-iotests: Add VM.run_job()
  qemu-iotests: iotests.py helper for non-file protocols
  qemu-iotests: Rewrite 206 for blockdev-create job
  qemu-iotests: Rewrite 207 for blockdev-create job
  qemu-iotests: Rewrite 210 for blockdev-create job
  qemu-iotests: Rewrite 211 for blockdev-create job
  qemu-iotests: Rewrite 212 for blockdev-create job
  qemu-iotests: Rewrite 213 for blockdev-create job
  block/create: Mark blockdev-create stable

 qapi/block-core.json          |  18 +-
 qapi/job.json                 |   4 +-
 include/qemu/job.h            |   7 +-
 block/backup.c                |   2 +-
 block/commit.c                |   2 +-
 block/create.c                |  67 +++--
 block/mirror.c                |   2 +-
 block/stream.c                |   2 +-
 block/vdi.c                   |   1 +
 block/vhdx.c                  |   2 +-
 job-qmp.c                     |   9 +-
 job.c                         |  16 +-
 tests/test-bdrv-drain.c       |   2 +-
 tests/test-blockjob-txn.c     |   2 +-
 tests/test-blockjob.c         |   2 +-
 tests/qemu-iotests/206        | 680 ++++++++++++++++--------------------------
 tests/qemu-iotests/206.out    | 253 +++++++++-------
 tests/qemu-iotests/207        | 440 ++++++++++++---------------
 tests/qemu-iotests/207.out    | 107 +++----
 tests/qemu-iotests/210        | 393 ++++++++++--------------
 tests/qemu-iotests/210.out    | 197 ++++++++----
 tests/qemu-iotests/211        | 381 ++++++++++-------------
 tests/qemu-iotests/211.out    | 133 +++++----
 tests/qemu-iotests/212        | 483 +++++++++++-------------------
 tests/qemu-iotests/212.out    | 191 +++++++-----
 tests/qemu-iotests/213        | 520 ++++++++++++--------------------
 tests/qemu-iotests/213.out    | 208 ++++++++-----
 tests/qemu-iotests/iotests.py |  78 +++++
 28 files changed, 1979 insertions(+), 2223 deletions(-)

-- 
2.13.6

             reply	other threads:[~2018-05-29 20:39 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29 20:38 Kevin Wolf [this message]
2018-05-29 20:38 ` [Qemu-devel] [PATCH v2 01/16] vdi: Fix vdi_co_do_create() return value Kevin Wolf
2018-05-29 20:38 ` [Qemu-devel] [PATCH v2 02/16] vhdx: Fix vhdx_co_create() " Kevin Wolf
2018-05-29 20:38 ` [Qemu-devel] [PATCH v2 03/16] job: Add error message for failing jobs Kevin Wolf
2018-05-30  4:15   ` Jeff Cody
2018-05-30  9:48   ` Max Reitz
2018-05-29 20:38 ` [Qemu-devel] [PATCH v2 04/16] block/create: Make x-blockdev-create a job Kevin Wolf
2018-05-30  4:22   ` Jeff Cody
2018-05-29 20:38 ` [Qemu-devel] [PATCH v2 05/16] qemu-iotests: Add VM.get_qmp_events_filtered() Kevin Wolf
2018-05-30  4:23   ` Jeff Cody
2018-05-29 20:39 ` [Qemu-devel] [PATCH v2 06/16] qemu-iotests: Add VM.qmp_log() Kevin Wolf
2018-05-30  9:57   ` Max Reitz
2018-05-29 20:39 ` [Qemu-devel] [PATCH v2 07/16] qemu-iotests: Add iotests.img_info_log() Kevin Wolf
2018-05-30  4:25   ` Jeff Cody
2018-05-30  9:59   ` Max Reitz
2018-05-29 20:39 ` [Qemu-devel] [PATCH v2 08/16] qemu-iotests: Add VM.run_job() Kevin Wolf
2018-05-30  4:35   ` Jeff Cody
2018-05-30 10:04   ` Max Reitz
2018-05-29 20:39 ` [Qemu-devel] [PATCH v2 09/16] qemu-iotests: iotests.py helper for non-file protocols Kevin Wolf
2018-05-30  4:33   ` Jeff Cody
2018-05-30 10:06   ` Max Reitz
2018-05-29 20:39 ` [Qemu-devel] [PATCH v2 10/16] qemu-iotests: Rewrite 206 for blockdev-create job Kevin Wolf
2018-05-30 10:09   ` Max Reitz
2018-05-29 20:39 ` [Qemu-devel] [PATCH v2 11/16] qemu-iotests: Rewrite 207 " Kevin Wolf
2018-05-30 10:15   ` Max Reitz
2018-05-29 20:39 ` [Qemu-devel] [PATCH v2 12/16] qemu-iotests: Rewrite 210 " Kevin Wolf
2018-05-29 20:39 ` [Qemu-devel] [PATCH v2 13/16] qemu-iotests: Rewrite 211 " Kevin Wolf
2018-05-29 20:39 ` [Qemu-devel] [PATCH v2 14/16] qemu-iotests: Rewrite 212 " Kevin Wolf
2018-05-29 20:39 ` [Qemu-devel] [PATCH v2 15/16] qemu-iotests: Rewrite 213 " Kevin Wolf
2018-05-29 20:39 ` [Qemu-devel] [PATCH v2 16/16] block/create: Mark blockdev-create stable Kevin Wolf
2018-05-29 21:01 ` [Qemu-devel] [PATCH v2 00/16] block: Make blockdev-create a job and stable API no-reply
2018-05-30  1:43 ` Jeff Cody
2018-05-30 13:31   ` Jeff Cody
2018-05-30 14:33 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180529203910.7615-1-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jcody@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).