From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNzwk-0007h9-Tv for qemu-devel@nongnu.org; Wed, 30 May 2018 08:11:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNzwg-0000GN-Lb for qemu-devel@nongnu.org; Wed, 30 May 2018 08:11:18 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:39186 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fNzwg-0000GH-G1 for qemu-devel@nongnu.org; Wed, 30 May 2018 08:11:14 -0400 Date: Wed, 30 May 2018 20:10:57 +0800 From: Peter Xu Message-ID: <20180530121057.GE27442@xz-mi> References: <20180521084249.10640-1-peterx@redhat.com> <8ef2c984-7817-a54f-ebae-a1f14e453b6a@redhat.com> <810f70e6-4ce7-2ad9-2f20-19fc6df57452@redhat.com> <20180530080458.GB27442@xz-mi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180530080458.GB27442@xz-mi> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: Eric Blake , qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , "Daniel P . Berrange" , Christian Borntraeger , Fam Zheng , Kevin Wolf , Max Reitz , Eric Auger , Peter Maydell , Markus Armbruster On Wed, May 30, 2018 at 04:04:58PM +0800, Peter Xu wrote: > On Tue, May 22, 2018 at 02:40:26PM -0400, John Snow wrote: > >=20 > >=20 > > On 05/21/2018 10:13 AM, Eric Blake wrote: > > > On 05/21/2018 03:42 AM, Peter Xu wrote: > > >> We turned Out-Of-Band feature of monitors off for 2.12 release.=C2= =A0 Now we > > >> try to turn that on again. > > >=20 > > > "try to turn" sounds weak, like you aren't sure of this patch.=C2=A0= If you > > > aren't sure, then why should we feel safe in applying it?=C2=A0 Thi= s text is > > > going in the permanent git history, so sound bold, rather than hesi= tant! > > >=20 > > > "We have resolved the issues from last time (commit 3fd2457d revert= ed by > > > commit a4f90923): > > > - issue 1 ... > > > - issue 2 ... > > > So now we are ready to enable advertisement of the feature by defau= lt" > > >=20 > > > with better descriptions of the issues that you fixed (I can think = of at > > > least the fixes adding thread-safety to the current monitor, and fi= xing > > > early use of the monitor before qmp_capabilities completes; there m= ay > > > also be other issues that you want to call out). > > >=20 > > >> > > >> Signed-off-by: Peter Xu > > >> --=20 > > >> Now OOB should be okay with all known tests (except iotest qcow2, = since > > >> it is still broken on master), > > >=20 > > > Which tests are still failing for you?=C2=A0 Ideally, you can still > > > demonstrate that the tests not failing without this patch continue = to > > > pass with this patch, even if you call out the tests that have know= n > > > issues to still be resolved. > > >=20 > >=20 > > Probably 91 and 169. If any others fail that's news to me. >=20 > I just gave it a shot on my workstation too (./check -qcow2): >=20 > Not run: 045 059 064 070 075 076 077 078 081 083 084 088 092 093 094 10= 1 106 109 113 116 119 123 128 131 135 136 146 148 149 160 162 171 173 175= 199 207 210 3 > Failures: 087 188 189 198 206 > Failed 5 of 167 tests >=20 > I'm testing against master, e609fa7. Hmm... I ran again the same test and the same master commit but this time it passed all 167 tests on my laptop. So I assume the previous 5 failures are unreproducable at least every time (or there might be something wrong with my testbed). I'll rerun some more times, and when I post the OOB patch I'll cover all correct qcow2 tests. Regards, --=20 Peter Xu