qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 08/17] qemu-iotests: Add iotests.img_info_log()
Date: Wed, 30 May 2018 17:56:38 +0200	[thread overview]
Message-ID: <20180530155647.14090-9-kwolf@redhat.com> (raw)
In-Reply-To: <20180530155647.14090-1-kwolf@redhat.com>

This adds a filter function to postprocess 'qemu-img info' input
(similar to what _img_info does), and an img_info_log() function that
calls 'qemu-img info' and logs the filtered output.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
---
 tests/qemu-iotests/iotests.py | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 2f54823db6..edcd2bb701 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -109,6 +109,12 @@ def qemu_img_pipe(*args):
         sys.stderr.write('qemu-img received signal %i: %s\n' % (-exitcode, ' '.join(qemu_img_args + list(args))))
     return subp.communicate()[0]
 
+def img_info_log(filename, filter_path=None):
+    output = qemu_img_pipe('info', '-f', imgfmt, filename)
+    if not filter_path:
+        filter_path = filename
+    log(filter_img_info(output, filter_path))
+
 def qemu_io(*args):
     '''Run qemu-io and return the stdout data'''
     args = qemu_io_args + list(args)
@@ -210,6 +216,18 @@ def filter_testfiles(msg):
     prefix = os.path.join(test_dir, "%s-" % (os.getpid()))
     return msg.replace(prefix, 'TEST_DIR/PID-')
 
+def filter_img_info(output, filename):
+    lines = []
+    for line in output.split('\n'):
+        if 'disk size' in line or 'actual-size' in line:
+            continue
+        line = line.replace(filename, 'TEST_IMG') \
+                   .replace(imgfmt, 'IMGFMT')
+        line = re.sub('iters: [0-9]+', 'iters: XXX', line)
+        line = re.sub('uuid: [-a-f0-9]+', 'uuid: XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX', line)
+        lines.append(line)
+    return '\n'.join(lines)
+
 def log(msg, filters=[]):
     for flt in filters:
         msg = flt(msg)
-- 
2.13.6

  parent reply	other threads:[~2018-05-30 15:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30 15:56 [Qemu-devel] [PULL 00/17] Block layer patches Kevin Wolf
2018-05-30 15:56 ` [Qemu-devel] [PULL 01/17] qcow2: Fix Coverity warning when calculating the refcount cache size Kevin Wolf
2018-05-30 15:56 ` [Qemu-devel] [PULL 02/17] vdi: Fix vdi_co_do_create() return value Kevin Wolf
2018-05-30 15:56 ` [Qemu-devel] [PULL 03/17] vhdx: Fix vhdx_co_create() " Kevin Wolf
2018-05-30 15:56 ` [Qemu-devel] [PULL 04/17] job: Add error message for failing jobs Kevin Wolf
2018-05-30 15:56 ` [Qemu-devel] [PULL 05/17] block/create: Make x-blockdev-create a job Kevin Wolf
2018-05-30 15:56 ` [Qemu-devel] [PULL 06/17] qemu-iotests: Add VM.get_qmp_events_filtered() Kevin Wolf
2018-05-30 15:56 ` [Qemu-devel] [PULL 07/17] qemu-iotests: Add VM.qmp_log() Kevin Wolf
2018-05-30 15:56 ` Kevin Wolf [this message]
2018-05-30 15:56 ` [Qemu-devel] [PULL 09/17] qemu-iotests: Add VM.run_job() Kevin Wolf
2018-05-30 15:56 ` [Qemu-devel] [PULL 10/17] qemu-iotests: iotests.py helper for non-file protocols Kevin Wolf
2018-05-30 15:56 ` [Qemu-devel] [PULL 11/17] qemu-iotests: Rewrite 206 for blockdev-create job Kevin Wolf
2018-05-30 15:56 ` [Qemu-devel] [PULL 12/17] qemu-iotests: Rewrite 207 " Kevin Wolf
2018-05-30 15:56 ` [Qemu-devel] [PULL 13/17] qemu-iotests: Rewrite 210 " Kevin Wolf
2018-05-30 15:56 ` [Qemu-devel] [PULL 14/17] qemu-iotests: Rewrite 211 " Kevin Wolf
2018-05-30 15:56 ` [Qemu-devel] [PULL 15/17] qemu-iotests: Rewrite 212 " Kevin Wolf
2018-05-30 15:56 ` [Qemu-devel] [PULL 16/17] qemu-iotests: Rewrite 213 " Kevin Wolf
2018-05-30 15:56 ` [Qemu-devel] [PULL 17/17] block/create: Mark blockdev-create stable Kevin Wolf
2018-05-30 16:18 ` [Qemu-devel] [PULL 00/17] Block layer patches no-reply
2018-05-31 10:12 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530155647.14090-9-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).