From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Fam Zheng" <famz@redhat.com>, "Kevin Wolf" <kwolf@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
peterx@redhat.com, "Eric Auger" <eric.auger@redhat.com>,
"Eric Blake" <eblake@redhat.com>, "John Snow" <jsnow@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [RFC v2 0/4] monitor: enable OOB by default
Date: Thu, 31 May 2018 13:16:37 +0800 [thread overview]
Message-ID: <20180531051641.8473-1-peterx@redhat.com> (raw)
Patch 1: some more comment suggested by Markus on Out-Of-Band
handlers.
Patch 2: touch up iotests to make sure after enabling OOB the randomly
generated SHUTDOWN event won't fail any tests. Without this change,
iotests (raw) will success but iotests (qcow2) may fail 2 tests out of
100+. With this patch applied, all tests pass. Kevin, Max, please
help have a look on this one.
Patch 3: revert the x-oob parameter, turn OOB on.
Patch 4: revert the x-oob parameter usage in test. We can consider
squash this patch into patch 3 to make sure no test will break.
However I kept it separate at least for review.
Tests passed:
- make check
- iotests on both raw and qcow2
Please review. Thanks,
Peter Xu (4):
docs: mention shared state protect for OOB
tests: iotests: don't compare SHUTDOWN event
monitor: remove "x-oob", turn oob on by default
Revert "tests: Add parameter to qtest_init_without_qmp_handshake"
docs/devel/qapi-code-gen.txt | 3 +++
include/monitor/monitor.h | 1 -
tests/libqtest.h | 7 ++----
monitor.c | 17 +-------------
tests/libqtest.c | 10 ++++----
tests/qmp-test.c | 6 ++---
vl.c | 5 ----
tests/qemu-iotests/060.out | 1 -
tests/qemu-iotests/067.out | 5 ++++
tests/qemu-iotests/071.out | 2 --
tests/qemu-iotests/081.out | 1 -
tests/qemu-iotests/087.out | 6 -----
tests/qemu-iotests/094.out | 1 -
tests/qemu-iotests/109.out | 22 ------------------
tests/qemu-iotests/117.out | 1 -
tests/qemu-iotests/119.out | 1 -
tests/qemu-iotests/120.out | 1 -
tests/qemu-iotests/127.out | 1 -
tests/qemu-iotests/140.out | 1 -
tests/qemu-iotests/143.out | 1 -
tests/qemu-iotests/156.out | 1 -
tests/qemu-iotests/176.out | 8 -------
tests/qemu-iotests/183.out | 2 --
tests/qemu-iotests/184.out | 40 --------------------------------
tests/qemu-iotests/185.out | 5 ----
tests/qemu-iotests/191.out | 20 ----------------
tests/qemu-iotests/195.out | 20 ----------------
tests/qemu-iotests/206.out | 11 ---------
tests/qemu-iotests/207.out | 6 -----
tests/qemu-iotests/210.out | 6 -----
tests/qemu-iotests/211.out | 7 ------
tests/qemu-iotests/212.out | 8 -------
tests/qemu-iotests/213.out | 9 -------
tests/qemu-iotests/common.filter | 5 +++-
34 files changed, 22 insertions(+), 219 deletions(-)
--
2.17.0
next reply other threads:[~2018-05-31 5:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 5:16 Peter Xu [this message]
2018-05-31 5:16 ` [Qemu-devel] [RFC v2 1/4] docs: mention shared state protect for OOB Peter Xu
2018-05-31 14:06 ` Eric Blake
2018-06-07 8:06 ` Peter Xu
2018-05-31 5:16 ` [Qemu-devel] [RFC v2 2/4] tests: iotests: don't compare SHUTDOWN event Peter Xu
2018-05-31 14:42 ` Eric Blake
2018-06-04 4:59 ` Peter Xu
2018-06-04 8:10 ` Peter Xu
2018-05-31 5:16 ` [Qemu-devel] [RFC v2 3/4] monitor: remove "x-oob", turn oob on by default Peter Xu
2018-05-31 14:44 ` Eric Blake
2018-06-07 8:08 ` Peter Xu
2018-06-07 11:40 ` Markus Armbruster
2018-06-08 6:32 ` Peter Xu
2018-05-31 5:16 ` [Qemu-devel] [RFC v2 4/4] Revert "tests: Add parameter to qtest_init_without_qmp_handshake" Peter Xu
2018-05-31 14:51 ` Eric Blake
2018-06-07 8:13 ` Peter Xu
2018-05-31 5:20 ` [Qemu-devel] [RFC v2 0/4] monitor: enable OOB by default Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531051641.8473-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=eric.auger@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).