Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] ahci: don't schedule unnecessary BH

[Jeff Cody <jcody@redhat.com>]

On Wed, May 30, 2018 at 08:43:23PM -0400, John Snow wrote:
> The comment gives us a hint. *Maybe* we still have something to
> process. Well, why not check?

Heh :)

Reviewed-by: Jeff Cody <jcody@redhat.com>

> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  hw/ide/ahci.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index a9558e45e7..380366b038 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -1427,8 +1427,7 @@ static void ahci_cmd_done(IDEDMA *dma)
>      /* update d2h status */
>      ahci_write_fis_d2h(ad);
>  
> -    if (!ad->check_bh) {
> -        /* maybe we still have something to process, check later */
> +    if (ad->port_regs.cmd_issue && !ad->check_bh) {
>          ad->check_bh = qemu_bh_new(ahci_check_cmd_bh, ad);
>          qemu_bh_schedule(ad->check_bh);
>      }
> -- 
> 2.14.3
> 
>