From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOZv9-0007D1-6V for qemu-devel@nongnu.org; Thu, 31 May 2018 22:36:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fOZv8-0007Bo-8S for qemu-devel@nongnu.org; Thu, 31 May 2018 22:36:03 -0400 Date: Fri, 1 Jun 2018 10:35:42 +0800 From: Fam Zheng Message-ID: <20180601023542.GD12136@lemon.usersys.redhat.com> References: <20180529055959.32002-1-famz@redhat.com> <20180530160647.GD5973@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180530160647.GD5973@stefanha-x1.localdomain> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v7 00/10] qemu-img convert with copy offloading List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Paolo Bonzini , Ronnie Sahlberg , qemu-block@nongnu.org, Peter Lieven , Kevin Wolf , Max Reitz , eblake@redhat.com On Wed, 05/30 17:06, Stefan Hajnoczi wrote: > On Tue, May 29, 2018 at 01:59:49PM +0800, Fam Zheng wrote: > > v7: Fix qcow2. > >=20 > > v6: Pick up rev-by from Stefan and Eric. > > Tweak patch 2 commit message. > >=20 > > v5: - Fix raw offset/bytes check for read. [Eric] > > - Fix qcow2_handle_l2meta. [Stefan] > > - Add coroutine_fn whereever appropriate. [Stefan] > >=20 > > v4: - Fix raw offset and size. [Eric] > > - iscsi: Drop unnecessary return values and variables in favor of > > constants. [Stefan] > > - qcow2: Handle small backing case. [Stefan] > > - file-posix: Translate ENOSYS to ENOTSUP. [Stefan] > > - API documentation and commit message. [Stefan] > > - Add rev-by to patches 3, 5 - 10. [Stefan, Eric] > >=20 > > This series introduces block layer API for copy offloading and makes = use of it > > in qemu-img convert. > >=20 > > For now we implemented the operation in local file protocol with > > copy_file_range(2). Besides that it's possible to add similar to isc= si, nfs > > and potentially more. > >=20 > > As far as its usage goes, in addition to qemu-img convert, we can emu= late > > offloading in scsi-disk (handle EXTENDED COPY command), and use the A= PI in > > block jobs too. >=20 > Fails to compile on Fedora 28. >=20 > Oops, I guess my glibc is too new. This type of bug doesn't happen ver= y > often :D :D :D. >=20 > block/file-posix.c:1452:14: error: static declaration of =E2=80=98copy_= file_range=E2=80=99 follows non-static declaration > static off_t copy_file_range(int in_fd, off_t *in_off, int out_fd, > ^~~~~~~~~~~~~~~ > In file included from /home/stefanha/qemu/include/qemu/osdep.h:75, > from block/file-posix.c:25: > /usr/include/unistd.h:1107:9: note: previous declaration of =E2=80=98co= py_file_range=E2=80=99 was here > ssize_t copy_file_range (int __infd, __off64_t *__pinoff, > ^~~~~~~~~~~~~~~ It means it's time to update our Fedora docker image! Will fix this by ad= ding a configure test. Fam