From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
"Emilio G. Cota" <cota@braap.org>, Eric Blake <eblake@redhat.com>
Subject: [Qemu-devel] [PULL 07/31] osdep: add wait.h compat macros
Date: Fri, 1 Jun 2018 19:26:54 +0300 [thread overview]
Message-ID: <20180601162620.32362-8-mst@redhat.com> (raw)
In-Reply-To: <20180601162620.32362-1-mst@redhat.com>
Man page for WCOREDUMP says:
WCOREDUMP(wstatus) returns true if the child produced a core dump.
This macro should be employed only if WIFSIGNALED returned true.
This macro is not specified in POSIX.1-2001 and is not
available on some UNIX implementations (e.g., AIX, SunOS). Therefore,
enclose its use inside #ifdef WCOREDUMP ... #endif.
Let's do exactly this.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/qemu/osdep.h | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index 41658060a7..afc28e5903 100644
--- a/include/qemu/osdep.h
+++ b/include/qemu/osdep.h
@@ -107,6 +107,16 @@ extern int daemon(int, int);
#include "glib-compat.h"
#include "qemu/typedefs.h"
+/*
+ * According to waitpid man page:
+ * WCOREDUMP
+ * This macro is not specified in POSIX.1-2001 and is not
+ * available on some UNIX implementations (e.g., AIX, SunOS).
+ * Therefore, enclose its use inside #ifdef WCOREDUMP ... #endif.
+ */
+#ifndef WCOREDUMP
+#define WCOREDUMP(status) 0
+#endif
/*
* We have a lot of unaudited code that may fail in strange ways, or
* even be a security risk during migration, if you disable assertions
--
MST
next prev parent reply other threads:[~2018-06-01 16:26 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 16:26 [Qemu-devel] [PULL 00/31] acpi, vhost, misc: fixes, features Michael S. Tsirkin
2018-06-01 16:26 ` [Qemu-devel] [PULL 01/31] vhost: allow backends to filter memory sections Michael S. Tsirkin
2018-06-01 16:26 ` [Qemu-devel] [PULL 03/31] vhost-user: introduce shared vhost-user state Michael S. Tsirkin
2018-06-01 16:26 ` [Qemu-devel] [PULL 02/31] vhost-user: allow slave to send fds via slave channel Michael S. Tsirkin
2018-06-01 16:26 ` [Qemu-devel] [PULL 04/31] vhost-user: support registering external host notifiers Michael S. Tsirkin
2018-06-01 16:26 ` [Qemu-devel] [PULL 05/31] libvhost-user: support host notifier Michael S. Tsirkin
2018-06-01 16:26 ` [Qemu-devel] [PULL 06/31] vhost-user-bridge: " Michael S. Tsirkin
2018-06-01 16:26 ` [Qemu-devel] [PULL 08/31] libqtest: fail if child coredumps Michael S. Tsirkin
2018-06-01 16:26 ` Michael S. Tsirkin [this message]
2018-06-01 16:26 ` [Qemu-devel] [PULL 09/31] block: use local path for local headers Michael S. Tsirkin
2018-06-01 16:26 ` [Qemu-devel] [PULL 10/31] crypto: " Michael S. Tsirkin
2018-06-01 16:26 ` [Qemu-devel] [PULL 12/31] migration: drop an unused include Michael S. Tsirkin
2018-06-01 16:26 ` [Qemu-devel] [PULL 11/31] hppa: use local path for local headers Michael S. Tsirkin
2018-06-01 16:26 ` [Qemu-devel] [PULL 13/31] trace: " Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 14/31] display: " Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 15/31] ide: " Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 16/31] ioapic: fix up includes Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 18/31] rocker: drop an unused include Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 17/31] e1000e: use local path for local headers Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 19/31] ppc: " Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 20/31] vhost-scsi: drop an unused include Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 21/31] sd: fix up include Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 22/31] usb: use local path for local headers Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 23/31] migration: " Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 24/31] colo: " Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 25/31] qga: " Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 26/31] ui: " Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 27/31] arch_init: sort architectures Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 28/31] tests/.gitignore: add entry for generated file Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 29/31] nvdimm, acpi: support NFIT platform capabilities Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 30/31] ACPI testing: test " Michael S. Tsirkin
2018-06-01 16:27 ` [Qemu-devel] [PULL 31/31] vhost-blk: turn on pre-defined RO feature bit Michael S. Tsirkin
2018-06-04 10:28 ` [Qemu-devel] [PULL 00/31] acpi, vhost, misc: fixes, features Peter Maydell
2018-06-08 17:52 ` Philippe Mathieu-Daudé
2018-06-08 18:47 ` Philippe Mathieu-Daudé
2018-06-09 11:38 ` Peter Maydell
2018-06-06 10:09 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601162620.32362-8-mst@redhat.com \
--to=mst@redhat.com \
--cc=cota@braap.org \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).