From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPmGx-000249-KO for qemu-devel@nongnu.org; Mon, 04 Jun 2018 05:59:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPmGs-0002e9-O1 for qemu-devel@nongnu.org; Mon, 04 Jun 2018 05:59:31 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59176 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fPmGs-0002dj-Iy for qemu-devel@nongnu.org; Mon, 04 Jun 2018 05:59:26 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1E393401EF05 for ; Mon, 4 Jun 2018 09:59:26 +0000 (UTC) Date: Mon, 4 Jun 2018 10:59:17 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20180604095917.GA2628@work-vm> References: <20180601162749.27406-1-marcandre.lureau@redhat.com> <20180601162749.27406-7-marcandre.lureau@redhat.com> <20180604090746.GA2629@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC v2 06/12] vhost-user: add vhost_user_input_get_config() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: qemu-devel , Gerd Hoffmann * Marc-Andr=E9 Lureau (marcandre.lureau@redhat.com) wrote: > Hi >=20 > On Mon, Jun 4, 2018 at 11:07 AM, Dr. David Alan Gilbert > wrote: > > * Marc-Andr=E9 Lureau (marcandre.lureau@redhat.com) wrote: > >> Ask vhost user input backend the list of virtio_input_config. > > > > Why is this vhost-user specific; shouldn't the vhost-input > > behaviour be the same irrespective of if it's vhost-user or plain vho= st? > > >=20 > A similar message could be used for plain vhost, in some ioctl form. > Here we are documenting vhost-user protocol only. The vhost-user protocol seems to be mostly independent of the device it's carrying; for example I see there's a 'net_set_mtu' and 'send_rarp' but I don't think there's anything for disk storage; what are the cases whether these have to be done through a change to the vhost-user protocol as opposed to stuff carried over it? Dave >=20 > Thanks >=20 > > Dave > > > > > >> Signed-off-by: Marc-Andr=E9 Lureau > >> --- > >> include/hw/virtio/vhost-backend.h | 4 +++ > >> hw/virtio/vhost-user.c | 59 ++++++++++++++++++++++++++++= +++ > >> docs/interop/vhost-user.txt | 6 ++++ > >> 3 files changed, 69 insertions(+) > >> > >> diff --git a/include/hw/virtio/vhost-backend.h b/include/hw/virtio/v= host-backend.h > >> index 5dac61f9ea..6cc2edacc5 100644 > >> --- a/include/hw/virtio/vhost-backend.h > >> +++ b/include/hw/virtio/vhost-backend.h > >> @@ -12,6 +12,7 @@ > >> #define VHOST_BACKEND_H > >> > >> #include "exec/memory.h" > >> +#include "standard-headers/linux/virtio_input.h" > >> > >> typedef enum VhostBackendType { > >> VHOST_BACKEND_TYPE_NONE =3D 0, > >> @@ -156,4 +157,7 @@ int vhost_backend_invalidate_device_iotlb(struct= vhost_dev *dev, > >> int vhost_backend_handle_iotlb_msg(struct vhost_dev *dev, > >> struct vhost_iotlb_msg *i= msg); > >> > >> +int vhost_user_input_get_config(struct vhost_dev *dev, > >> + struct virtio_input_config **config= ); > >> + > >> #endif /* VHOST_BACKEND_H */ > >> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c > >> index a87db01e55..19ed87d07c 100644 > >> --- a/hw/virtio/vhost-user.c > >> +++ b/hw/virtio/vhost-user.c > >> @@ -84,6 +84,7 @@ typedef enum VhostUserRequest { > >> VHOST_USER_POSTCOPY_ADVISE =3D 28, > >> VHOST_USER_POSTCOPY_LISTEN =3D 29, > >> VHOST_USER_POSTCOPY_END =3D 30, > >> + VHOST_USER_INPUT_GET_CONFIG, > >> VHOST_USER_MAX > >> } VhostUserRequest; > >> > >> @@ -324,6 +325,64 @@ static int vhost_user_write(struct vhost_dev *d= ev, VhostUserMsg *msg, > >> return 0; > >> } > >> > >> +static void *vhost_user_read_size(struct vhost_dev *dev, uint32_t s= ize) > >> +{ > >> + struct vhost_user *u =3D dev->opaque; > >> + CharBackend *chr =3D u->chr; > >> + int r; > >> + uint8_t *p =3D g_malloc(size); > >> + > >> + r =3D qemu_chr_fe_read_all(chr, p, size); > >> + if (r !=3D size) { > >> + error_report("Failed to read msg payload." > >> + " Read %d instead of %d.", r, size); > >> + return NULL; > >> + } > >> + > >> + return p; > >> +} > >> + > >> +int vhost_user_input_get_config(struct vhost_dev *dev, > >> + struct virtio_input_config **config= ) > >> +{ > >> + void *p =3D NULL; > >> + VhostUserMsg msg =3D { > >> + .hdr.request =3D VHOST_USER_INPUT_GET_CONFIG, > >> + .hdr.flags =3D VHOST_USER_VERSION, > >> + }; > >> + > >> + if (vhost_user_write(dev, &msg, NULL, 0) < 0) { > >> + goto err; > >> + } > >> + > >> + if (vhost_user_read_header(dev, &msg) < 0) { > >> + goto err; > >> + } > >> + > >> + p =3D vhost_user_read_size(dev, msg.hdr.size); > >> + if (!p) { > >> + goto err; > >> + } > >> + > >> + if (msg.hdr.request !=3D VHOST_USER_INPUT_GET_CONFIG) { > >> + error_report("Received unexpected msg type. Expected %d rec= eived %d", > >> + VHOST_USER_INPUT_GET_CONFIG, msg.hdr.request); > >> + goto err; > >> + } > >> + > >> + if (msg.hdr.size % sizeof(struct virtio_input_config)) { > >> + error_report("Invalid msg size"); > >> + goto err; > >> + } > >> + > >> + *config =3D p; > >> + return msg.hdr.size / sizeof(struct virtio_input_config); > >> + > >> +err: > >> + g_free(p); > >> + return -1; > >> +} > >> + > >> static int vhost_user_set_log_base(struct vhost_dev *dev, uint64_t = base, > >> struct vhost_log *log) > >> { > >> diff --git a/docs/interop/vhost-user.txt b/docs/interop/vhost-user.t= xt > >> index 534caab18a..3df9927386 100644 > >> --- a/docs/interop/vhost-user.txt > >> +++ b/docs/interop/vhost-user.txt > >> @@ -744,6 +744,12 @@ Master message types > >> was previously sent. > >> The value returned is an error indication; 0 is success. > >> > >> + * VHOST_USER_INPUT_GET_CONFIG > >> + > >> + Slave payload: (struct virtio_input_config)* > >> + > >> + Ask vhost user input backend the list of virtio_input_config. > >> + > >> Slave message types > >> ------------------- > >> > >> -- > >> 2.17.1.906.g10fd178552 > >> > >> > > -- > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK