From: Eduardo Habkost <ehabkost@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Michal Privoznik <mprivozn@redhat.com>,
imammedo@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] cli: Don't run early event loop if no --preconfig was specified
Date: Mon, 4 Jun 2018 21:41:46 -0300 [thread overview]
Message-ID: <20180605004146.GD3184@localhost.localdomain> (raw)
In-Reply-To: <20180604103244.GD19749@redhat.com>
On Mon, Jun 04, 2018 at 11:32:44AM +0100, Daniel P. Berrangé wrote:
[...]
> Avoiding the double-run of main_loop is good, however, I think we should
> also not have put current_run_state in RUN_STATE_PRECONFIG in the first
> place if --preconfig wasn't set. I've sent a patch to fix that problem
> too, so if yours is also applied, it could be changed to just do:
>
> if (current_run_state == RNU_STATE_PRECONFIG) {
> main_loop();
> }
So, this patch is desirable even if we refactor the state machine
as suggested in the other threads, right?
I'm queueing it on machine-next right now.
--
Eduardo
next prev parent reply other threads:[~2018-06-05 0:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 10:34 [Qemu-devel] [PATCH] cli: Don't run early event loop if no --preconfig was specified Michal Privoznik
2018-06-04 10:32 ` Daniel P. Berrangé
2018-06-05 0:41 ` Eduardo Habkost [this message]
2018-06-05 11:43 ` Igor Mammedov
2018-06-05 12:06 ` Igor Mammedov
2018-06-04 11:44 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605004146.GD3184@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=berrange@redhat.com \
--cc=imammedo@redhat.com \
--cc=mprivozn@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).