From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQ0Ob-0000Vj-Kf for qemu-devel@nongnu.org; Mon, 04 Jun 2018 21:04:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQ0OW-0007oR-Nq for qemu-devel@nongnu.org; Mon, 04 Jun 2018 21:04:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43992) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQ0OW-0007mh-HV for qemu-devel@nongnu.org; Mon, 04 Jun 2018 21:04:16 -0400 Date: Mon, 4 Jun 2018 22:04:13 -0300 From: Eduardo Habkost Message-ID: <20180605010413.GF3184@localhost.localdomain> References: <1528143278-247932-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1528143278-247932-1-git-send-email-imammedo@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] vl.c: make default main_loop_wait() timeout independed of slirp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, ldoktor@redhat.com, jan.kiszka@siemens.com, mreitz@redhat.com, mprivozn@redhat.com, pbonzini@redhat.com On Mon, Jun 04, 2018 at 10:14:38PM +0200, Igor Mammedov wrote: > Since commit (047f7038f58 cli: add --preconfig option) QEMU is > stuck with indefinite timeout in os_host_main_loop_wait() > at RUN_STATE_PRECONFIG even if --preconfig option wasn't used > when it's started with -nodefaults CLI option like this: >=20 > ./s390x-softmmu/qemu-system-s390x -nodefaults >=20 > It's caused by the fact that slirp_pollfds_fill() bails out early > and slirp_update_timeout() won't be called to update timeout > to a reasonable value (1 sec) so timeout would be left with > infinite value (0xFFFFFFFF). >=20 > Default infinite timeout though doen't make sense and reducing > it to 1 second as in slirp_update_timeout() won't affect host. I don't get this part. Why default infinite timeout doesn't make sense? Why would a 1 second timeout make sense? > Fix issue by simplifying default timeout to the same 1sec as it > is in slirp_update_timeout() and cleanup the later. It makes > default timeout the same regardless of slirp_pollfds_fill() > exited early or not (i.e. -nodefaults won't have any effect on > main_loop_wait() anymore, which would provide more consistent > behavior between both variants of startup). >=20 > Reported-by: Luk=C3=A1=C5=A1 Doktor > Signed-off-by: Igor Mammedov > --- > PS: > it doesn't fix issue reported by Max where > "echo foo | $QEMU" > is also broken due to commit 047f7038f58, but there is antoher fix > on the list to fix that (either Michal's or Daniel's). [...] --=20 Eduardo