From: Gerd Hoffmann <kraxel@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 3/3] usb/dev-mtp: Fix use of uninitialized values
Date: Tue, 5 Jun 2018 11:21:58 +0200 [thread overview]
Message-ID: <20180605092158.ccdboal2fpvb3rpw@sirius.home.kraxel.org> (raw)
In-Reply-To: <20180604151421.23385-4-f4bug@amsat.org>
> + for (i = c->argc; i < ARRAY_SIZE(c->argv); i++) {
> + c->argv[i] = 0;
> + }
I think the code filling c->argv (in usb_mtp_handle_data) should so
that. Or just memset(0) cmd in usb_mtp_handle_data ...
cheers,
Gerd
PS: the other patches are fine.
prev parent reply other threads:[~2018-06-05 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 15:14 [Qemu-devel] [PATCH v2 0/3] usb: fix bugs reported by Clang Static Analyzer Philippe Mathieu-Daudé
2018-06-04 15:14 ` [Qemu-devel] [PATCH v2 1/3] usb: correctly handle Zero Length Packets Philippe Mathieu-Daudé
2018-06-04 15:14 ` [Qemu-devel] [PATCH v2 2/3] usb/dev-mtp: Fix use of uninitialized values Philippe Mathieu-Daudé
2018-06-04 15:14 ` [Qemu-devel] [PATCH v2 3/3] " Philippe Mathieu-Daudé
2018-06-05 9:21 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605092158.ccdboal2fpvb3rpw@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).