From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQAMx-0005LA-W3 for qemu-devel@nongnu.org; Tue, 05 Jun 2018 07:43:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQAMu-0007vz-VC for qemu-devel@nongnu.org; Tue, 05 Jun 2018 07:43:20 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:45572 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQAMu-0007vo-R8 for qemu-devel@nongnu.org; Tue, 05 Jun 2018 07:43:16 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 660D6195467 for ; Tue, 5 Jun 2018 11:43:16 +0000 (UTC) Date: Tue, 5 Jun 2018 13:43:14 +0200 From: Igor Mammedov Message-ID: <20180605134314.651edcee@redhat.com> In-Reply-To: <20180605004146.GD3184@localhost.localdomain> References: <20180604103244.GD19749@redhat.com> <20180605004146.GD3184@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] cli: Don't run early event loop if no --preconfig was specified List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: "Daniel P. =?UTF-8?B?QmVycmFuZ8Op?=" , Michal Privoznik , pbonzini@redhat.com, qemu-devel@nongnu.org On Mon, 4 Jun 2018 21:41:46 -0300 Eduardo Habkost wrote: > On Mon, Jun 04, 2018 at 11:32:44AM +0100, Daniel P. Berrang=C3=A9 wrote: > [...] > > Avoiding the double-run of main_loop is good, however, I think we should > > also not have put current_run_state in RUN_STATE_PRECONFIG in the first > > place if --preconfig wasn't set. I've sent a patch to fix that problem > > too, so if yours is also applied, it could be changed to just do: > >=20 > > if (current_run_state =3D=3D RNU_STATE_PRECONFIG) { > > main_loop(); > > } =20 >=20 > So, this patch is desirable even if we refactor the state machine > as suggested in the other threads, right? >=20 > I'm queueing it on machine-next right now. >=20 Maybe add a note to commit message that it also fixes qemu hang when -nodefaults CLI option is used. Also we would need Daniel's [PATCH v2 2/2] vl: fix use of --daemonize with --preconfig to fix the same issue with demonize but in case --preconfig were used