Re: [Qemu-devel] [PATCH] cli: Don't run early event loop if no --preconfig was specified

[Igor Mammedov <imammedo@redhat.com>]

On Tue, 5 Jun 2018 13:43:14 +0200
Igor Mammedov <imammedo@redhat.com> wrote:

> On Mon, 4 Jun 2018 21:41:46 -0300
> Eduardo Habkost <ehabkost@redhat.com> wrote:
> 
> > On Mon, Jun 04, 2018 at 11:32:44AM +0100, Daniel P. Berrangé wrote:
> > [...]  
> > > Avoiding the double-run of main_loop is good, however, I think we should
> > > also not have put current_run_state in RUN_STATE_PRECONFIG in the first
> > > place if --preconfig wasn't set.  I've sent a patch to fix that problem
> > > too, so if yours is also applied, it could be changed to just do:
> > > 
> > >     if (current_run_state == RNU_STATE_PRECONFIG) {
> > >         main_loop();
> > >     }    
> > 
> > So, this patch is desirable even if we refactor the state machine
> > as suggested in the other threads, right?
> > 
> > I'm queueing it on machine-next right now.
> >   
> Maybe add a note to commit message that it also fixes
> qemu hang when -nodefaults CLI option is used.
> 
> Also we would need Daniel's
> 
>   [PATCH v2 2/2] vl: fix use of --daemonize with  --preconfig
> 
> to fix the same issue with demonize but in case --preconfig were used
> 

iotests are still broken even with it, so I'm looking into it right now