* [Qemu-devel] [PATCH v2] linux-user: disable qemu-bridge-helper and socket_scm_helper build
@ 2018-06-05 16:09 Laurent Vivier
2018-06-05 16:12 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Vivier @ 2018-06-05 16:09 UTC (permalink / raw)
To: qemu-devel
Cc: Daniel P . Berrangé, Peter Maydell, Richard Henderson,
Laurent Vivier
linux-user targets don't need them, and if we ask to build statically
linked binaries, some static libraries they need are not available.
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
Notes:
v2:
replace "ifeq ($(CONFIG_SOFTMMU),y)" by
$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX))
Makefile | 2 +-
tests/Makefile.include | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 6d588d1f71..be589cf1c5 100644
--- a/Makefile
+++ b/Makefile
@@ -351,7 +351,7 @@ $(call set-vpath, $(SRC_PATH))
LIBS+=-lz $(LIBS_TOOLS)
-HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF)
+HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = qemu-bridge-helper$(EXESUF)
ifdef BUILD_DOCS
DOCS=qemu-doc.html qemu-doc.txt qemu.1 qemu-img.1 qemu-nbd.8 qemu-ga.8
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 86f90c0cb0..cb6c05dc33 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -923,7 +923,7 @@ check-report.html: check-report.xml
# Other tests
-QEMU_IOTESTS_HELPERS-$(CONFIG_LINUX) = tests/qemu-iotests/socket_scm_helper$(EXESUF)
+QEMU_IOTESTS_HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = tests/qemu-iotests/socket_scm_helper$(EXESUF)
.PHONY: check-tests/qemu-iotests-quick.sh
check-tests/qemu-iotests-quick.sh: tests/qemu-iotests-quick.sh qemu-img$(EXESUF) qemu-io$(EXESUF) $(QEMU_IOTESTS_HELPERS-y)
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH v2] linux-user: disable qemu-bridge-helper and socket_scm_helper build
2018-06-05 16:09 [Qemu-devel] [PATCH v2] linux-user: disable qemu-bridge-helper and socket_scm_helper build Laurent Vivier
@ 2018-06-05 16:12 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2018-06-05 16:12 UTC (permalink / raw)
To: Laurent Vivier
Cc: QEMU Developers, Daniel P . Berrangé, Richard Henderson
On 5 June 2018 at 17:09, Laurent Vivier <laurent@vivier.eu> wrote:
> linux-user targets don't need them, and if we ask to build statically
> linked binaries, some static libraries they need are not available.
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-05 16:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-05 16:09 [Qemu-devel] [PATCH v2] linux-user: disable qemu-bridge-helper and socket_scm_helper build Laurent Vivier
2018-06-05 16:12 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).