From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Fam Zheng <famz@redhat.com>, John Snow <jsnow@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>, Eric Blake <eblake@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] [PATCH 0/5] block dirty bitmaps: support libvirt API
Date: Tue, 5 Jun 2018 14:59:00 -0400 [thread overview]
Message-ID: <20180605185905.4583-1-jsnow@redhat.com> (raw)
This is largely the same series that Vladimir sent in January, but at
the time I was unsure of if we'd want these commands or not in QEMU.
After discussing with Virtuozzo their plans for a checkpoint-like API
implemented primarily in libvirt, I agree that these commands are at
least tentatively useful.
Eric Blake is currently writing a counter-proposal and demo API to show
to Virtuozzo on libvirt's development list. Check in these QMP commands
with the experimental prefix 'x-' for now so that it can be used for
prototyping.
Once the design for the libvirt API looks reasonably final I will
remove the 'x-' prefixes, or, if we wind up not using these particular
commands I will delete them entirely.
v3:
- Drop patch one (already merged)
- Minor phrasing adjustments to documentation
- Removed &state->bs argument to bitmap lookup for enable/disable
- Added x- prefix to all three commands and to add's new argument.
Vladimir's original cover letter is below:
There are three qmp commands, needed to implement external backup API.
Using these three commands, client may do all needed bitmap management by
hand:
on backup start we need to do a transaction:
{disable old bitmap, create new bitmap}
on backup success:
drop old bitmap
on backup fail:
enable old bitmap
merge new bitmap to old bitmap
drop new bitmap
John Snow (1):
qapi: add x-block-dirty-bitmap-enable/disable
Vladimir Sementsov-Ogievskiy (4):
block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap
qmp: transaction support for x-block-dirty-bitmap-enable/disable
qapi: add x-block-dirty-bitmap-merge
qapi: add disabled parameter to block-dirty-bitmap-add
block/dirty-bitmap.c | 24 ++++++-
blockdev.c | 163 ++++++++++++++++++++++++++++++++++++++++++-
include/block/dirty-bitmap.h | 3 +-
qapi/block-core.json | 86 ++++++++++++++++++++++-
qapi/transaction.json | 4 ++
5 files changed, 275 insertions(+), 5 deletions(-)
--
2.14.3
next reply other threads:[~2018-06-05 18:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 18:59 John Snow [this message]
2018-06-05 18:59 ` [Qemu-devel] [PATCH 1/5] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap John Snow
2018-06-06 13:23 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-06-05 18:59 ` [Qemu-devel] [PATCH 2/5] qapi: add x-block-dirty-bitmap-enable/disable John Snow
2018-06-06 13:21 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-06-06 17:46 ` [Qemu-devel] " John Snow
2018-06-05 18:59 ` [Qemu-devel] [PATCH 3/5] qmp: transaction support for x-block-dirty-bitmap-enable/disable John Snow
2018-06-05 18:59 ` [Qemu-devel] [PATCH 4/5] qapi: add x-block-dirty-bitmap-merge John Snow
2018-06-05 21:13 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-06-05 21:56 ` John Snow
2018-06-05 18:59 ` [Qemu-devel] [PATCH 5/5] qapi: add disabled parameter to block-dirty-bitmap-add John Snow
2018-06-06 13:19 ` [Qemu-devel] [Qemu-block] " Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605185905.4583-1-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).