From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 1/6] vfio: remove DPRINTF() definition from vfio-common.h
Date: Tue, 05 Jun 2018 14:06:15 -0600 [thread overview]
Message-ID: <20180605200615.24323.78444.stgit@gimli.home> (raw)
In-Reply-To: <20180605200425.24323.56023.stgit@gimli.home>
From: Tiwei Bie <tiwei.bie@intel.com>
This macro isn't used by any VFIO code. And its name is
too generic. The vfio-common.h (in include/hw/vfio) can
be included by other modules in QEMU. It can introduce
conflicts.
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
include/hw/vfio/vfio-common.h | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
index 8264a65fa550..a9036929b220 100644
--- a/include/hw/vfio/vfio-common.h
+++ b/include/hw/vfio/vfio-common.h
@@ -33,15 +33,6 @@
#define ERR_PREFIX "vfio error: %s: "
#define WARN_PREFIX "vfio warning: %s: "
-/*#define DEBUG_VFIO*/
-#ifdef DEBUG_VFIO
-#define DPRINTF(fmt, ...) \
- do { fprintf(stderr, "vfio: " fmt, ## __VA_ARGS__); } while (0)
-#else
-#define DPRINTF(fmt, ...) \
- do { } while (0)
-#endif
-
enum {
VFIO_DEVICE_TYPE_PCI = 0,
VFIO_DEVICE_TYPE_PLATFORM = 1,
next prev parent reply other threads:[~2018-06-05 20:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 20:06 [Qemu-devel] [PULL 0/6] VFIO updates 2018-06-05 Alex Williamson
2018-06-05 20:06 ` Alex Williamson [this message]
2018-06-05 20:06 ` [Qemu-devel] [PULL 2/6] vfio/quirks: Add common quirk alloc helper Alex Williamson
2018-06-05 20:06 ` [Qemu-devel] [PULL 3/6] vfio/quirks: Add quirk reset callback Alex Williamson
2018-06-05 20:06 ` [Qemu-devel] [PULL 4/6] vfio/quirks: ioeventfd quirk acceleration Alex Williamson
2018-06-05 20:06 ` [Qemu-devel] [PULL 5/6] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly Alex Williamson
2018-06-05 20:07 ` [Qemu-devel] [PULL 6/6] vfio/pci: Default display option to "off" Alex Williamson
2018-06-06 10:29 ` [Qemu-devel] [PULL 0/6] VFIO updates 2018-06-05 no-reply
2018-06-07 9:24 ` Fam Zheng
2018-06-07 8:55 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605200615.24323.78444.stgit@gimli.home \
--to=alex.williamson@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).