From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 6/6] vfio/pci: Default display option to "off"
Date: Tue, 05 Jun 2018 14:07:00 -0600 [thread overview]
Message-ID: <20180605200700.24323.45867.stgit@gimli.home> (raw)
In-Reply-To: <20180605200425.24323.56023.stgit@gimli.home>
Commit a9994687cb9b ("vfio/display: core & wireup") added display
support to vfio-pci with the default being "auto", which breaks
existing VMs when the vGPU requires GL support but had no previous
requirement for a GL compatible configuration. "Off" is the safer
default as we impose no new requirements to VM configurations.
Fixes: a9994687cb9b ("vfio/display: core & wireup")
Cc: qemu-stable@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
hw/vfio/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 84e27c7bb2d1..18c493b49ec1 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -3160,7 +3160,7 @@ static Property vfio_pci_dev_properties[] = {
DEFINE_PROP_PCI_HOST_DEVADDR("host", VFIOPCIDevice, host),
DEFINE_PROP_STRING("sysfsdev", VFIOPCIDevice, vbasedev.sysfsdev),
DEFINE_PROP_ON_OFF_AUTO("display", VFIOPCIDevice,
- display, ON_OFF_AUTO_AUTO),
+ display, ON_OFF_AUTO_OFF),
DEFINE_PROP_UINT32("x-intx-mmap-timeout-ms", VFIOPCIDevice,
intx.mmap_timeout, 1100),
DEFINE_PROP_BIT("x-vga", VFIOPCIDevice, features,
next prev parent reply other threads:[~2018-06-05 20:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 20:06 [Qemu-devel] [PULL 0/6] VFIO updates 2018-06-05 Alex Williamson
2018-06-05 20:06 ` [Qemu-devel] [PULL 1/6] vfio: remove DPRINTF() definition from vfio-common.h Alex Williamson
2018-06-05 20:06 ` [Qemu-devel] [PULL 2/6] vfio/quirks: Add common quirk alloc helper Alex Williamson
2018-06-05 20:06 ` [Qemu-devel] [PULL 3/6] vfio/quirks: Add quirk reset callback Alex Williamson
2018-06-05 20:06 ` [Qemu-devel] [PULL 4/6] vfio/quirks: ioeventfd quirk acceleration Alex Williamson
2018-06-05 20:06 ` [Qemu-devel] [PULL 5/6] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly Alex Williamson
2018-06-05 20:07 ` Alex Williamson [this message]
2018-06-06 10:29 ` [Qemu-devel] [PULL 0/6] VFIO updates 2018-06-05 no-reply
2018-06-07 9:24 ` Fam Zheng
2018-06-07 8:55 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605200700.24323.45867.stgit@gimli.home \
--to=alex.williamson@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).