From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: [Qemu-devel] [RFC PATCH 11/11] target/xtensa: Add trailing '\n' to qemu_log() calls
Date: Wed, 6 Jun 2018 12:21:28 -0300 [thread overview]
Message-ID: <20180606152128.449-12-f4bug@amsat.org> (raw)
In-Reply-To: <20180606152128.449-1-f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
RFC because I think the qemu_log_mask() was previously intended to concatenate
output to stderr... (multiple registers described on a single line).
target/xtensa/translate.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index 89db23852b..a11162eebe 100644
--- a/target/xtensa/translate.c
+++ b/target/xtensa/translate.c
@@ -2234,7 +2234,7 @@ static void translate_rur(DisasContext *dc, const uint32_t arg[],
if (uregnames[par[0]].name) {
tcg_gen_mov_i32(cpu_R[arg[0]], cpu_UR[par[0]]);
} else {
- qemu_log_mask(LOG_UNIMP, "RUR %d not implemented, ", par[0]);
+ qemu_log_mask(LOG_UNIMP, "RUR %d not implemented\n", par[0]);
}
}
}
@@ -2375,7 +2375,7 @@ static void translate_slli(DisasContext *dc, const uint32_t arg[],
{
if (gen_window_check2(dc, arg[0], arg[1])) {
if (arg[2] == 32) {
- qemu_log_mask(LOG_GUEST_ERROR, "slli a%d, a%d, 32 is undefined",
+ qemu_log_mask(LOG_GUEST_ERROR, "slli a%d, a%d, 32 is undefined\n",
arg[0], arg[1]);
}
tcg_gen_shli_i32(cpu_R[arg[0]], cpu_R[arg[1]], arg[2] & 0x1f);
@@ -2571,7 +2571,7 @@ static void translate_wur(DisasContext *dc, const uint32_t arg[],
if (uregnames[par[0]].name) {
gen_wur(par[0], cpu_R[arg[0]]);
} else {
- qemu_log_mask(LOG_UNIMP, "WUR %d not implemented, ", par[0]);
+ qemu_log_mask(LOG_UNIMP, "WUR %d not implemented\n", par[0]);
}
}
}
--
2.17.1
next prev parent reply other threads:[~2018-06-06 15:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 15:21 [Qemu-devel] [PATCH 00/11] misc: Add trailing '\n' to qemu_log() calls Philippe Mathieu-Daudé
2018-06-06 15:21 ` [Qemu-devel] [PATCH 01/11] hw/sd/milkymist-memcard: Add trailing '\n' to qemu_log() call Philippe Mathieu-Daudé
2018-06-06 15:21 ` [Qemu-devel] [PATCH 02/11] hw/digic: Add trailing '\n' to qemu_log() calls Philippe Mathieu-Daudé
2018-06-06 15:21 ` [Qemu-devel] [PATCH 03/11] xilinx-dp: Add trailing '\n' to qemu_log() call Philippe Mathieu-Daudé
2018-06-06 15:51 ` Alistair Francis
2018-06-06 15:21 ` [Qemu-devel] [PATCH 04/11] ppc/pnv: Add trailing '\n' to qemu_log() calls Philippe Mathieu-Daudé
2018-06-07 2:16 ` David Gibson
2018-06-07 2:26 ` Philippe Mathieu-Daudé
2018-06-06 15:21 ` [Qemu-devel] [PATCH 05/11] hw/core/register: Add trailing '\n' to qemu_log() call Philippe Mathieu-Daudé
2018-06-06 15:52 ` Alistair Francis
2018-06-06 15:21 ` [Qemu-devel] [PATCH 06/11] hw/mips/boston: Add trailing '\n' to qemu_log() calls Philippe Mathieu-Daudé
2018-06-06 15:21 ` [Qemu-devel] [PATCH 07/11] stellaris: " Philippe Mathieu-Daudé
2018-06-06 15:21 ` [Qemu-devel] [PATCH 08/11] target/arm: " Philippe Mathieu-Daudé
2018-06-06 15:21 ` [Qemu-devel] [PATCH 09/11] target/m68k: Add trailing '\n' to qemu_log() call Philippe Mathieu-Daudé
2018-06-06 15:26 ` Laurent Vivier
2018-06-06 15:21 ` [Qemu-devel] [PATCH 10/11] RISC-V: Add trailing '\n' to qemu_log() calls Philippe Mathieu-Daudé
2018-06-06 15:21 ` Philippe Mathieu-Daudé [this message]
2018-06-06 16:44 ` [Qemu-devel] [RFC PATCH 11/11] target/xtensa: " Max Filippov
2018-06-06 19:43 ` [Qemu-devel] [PATCH 00/11] misc: " John Snow
2018-06-08 10:54 ` Peter Maydell
2018-06-08 15:07 ` John Snow
2018-06-08 11:54 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180606152128.449-12-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).