[Qemu-devel] [PATCH 0/3] mac_newworld: add MAINTAINERS entries, fix qemu_log trailing '\n'

[Qemu-devel] [PATCH 0/3] mac_newworld: add MAINTAINERS entries, fix qemu_log trailing '\n'

[Philippe Mathieu-Daudé]

Nothing very exciting here.
I sometimes miss to notice some trace events, running with -d unimp,trace...
then using 'grep ^...'. This is only due to a missing '\n' :)

Philippe Mathieu-Daudé (3):
  MAINTAINERS: Add an entry for the MacIO device headers
  MAINTAINERS: Add entries for the MOS6522 VIA device
  hw/misc/mos6522: Add trailing '\n' to qemu_log() calls

 hw/misc/mos6522.c | 4 ++--
 MAINTAINERS       | 5 ++++-
 2 files changed, 6 insertions(+), 3 deletions(-)

-- 
2.17.1

[Qemu-devel] [PATCH 1/3] MAINTAINERS: Add an entry for the MacIO device headers

[Philippe Mathieu-Daudé]

Missed while moved in 7092e84d42b.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 41cd3736a9..2423b248fb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -766,8 +766,9 @@ F: hw/ppc/mac_newworld.c
 F: hw/pci-host/uninorth.c
 F: hw/pci-bridge/dec.[hc]
 F: hw/misc/macio/
-F: include/hw/ppc/mac_dbdma.h
 F: hw/nvram/mac_nvram.c
+F: include/hw/misc/macio/
+F: include/hw/ppc/mac_dbdma.h
 
 Old World
 M: Alexander Graf <agraf@suse.de>
-- 
2.17.1

[Qemu-devel] [PATCH 2/3] MAINTAINERS: Add entries for the MOS6522 VIA device

[Philippe Mathieu-Daudé]

Introduced in 51f233ec92c.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2423b248fb..c0922765f6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -766,8 +766,10 @@ F: hw/ppc/mac_newworld.c
 F: hw/pci-host/uninorth.c
 F: hw/pci-bridge/dec.[hc]
 F: hw/misc/macio/
+F: hw/misc/mos6522.c
 F: hw/nvram/mac_nvram.c
 F: include/hw/misc/macio/
+F: include/hw/misc/mos6522.h
 F: include/hw/ppc/mac_dbdma.h
 
 Old World
-- 
2.17.1

[Qemu-devel] [PATCH 3/3] hw/misc/mos6522: Add trailing '\n' to qemu_log() calls

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/misc/mos6522.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/misc/mos6522.c b/hw/misc/mos6522.c
index 6163cea6ab..49166cb8ad 100644
--- a/hw/misc/mos6522.c
+++ b/hw/misc/mos6522.c
@@ -189,12 +189,12 @@ static uint64_t mos6522_get_load_time(MOS6522State *s, MOS6522Timer *ti)
 
 static void mos6522_portA_write(MOS6522State *s)
 {
-    qemu_log_mask(LOG_UNIMP, "portA_write unimplemented");
+    qemu_log_mask(LOG_UNIMP, "portA_write unimplemented\n");
 }
 
 static void mos6522_portB_write(MOS6522State *s)
 {
-    qemu_log_mask(LOG_UNIMP, "portB_write unimplemented");
+    qemu_log_mask(LOG_UNIMP, "portB_write unimplemented\n");
 }
 
 uint64_t mos6522_read(void *opaque, hwaddr addr, unsigned size)
-- 
2.17.1

Re: [Qemu-devel] [PATCH 0/3] mac_newworld: add MAINTAINERS entries, fix qemu_log trailing '\n'

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

On Wed, Jun 06, 2018 at 11:59:18AM -0300, Philippe Mathieu-Daudé wrote:
> Nothing very exciting here.
> I sometimes miss to notice some trace events, running with -d unimp,trace...
> then using 'grep ^...'. This is only due to a missing '\n' :)

Applied to ppc-for-3.0, thanks.

> 
> Philippe Mathieu-Daudé (3):
>   MAINTAINERS: Add an entry for the MacIO device headers
>   MAINTAINERS: Add entries for the MOS6522 VIA device
>   hw/misc/mos6522: Add trailing '\n' to qemu_log() calls
> 
>  hw/misc/mos6522.c | 4 ++--
>  MAINTAINERS       | 5 ++++-
>  2 files changed, 6 insertions(+), 3 deletions(-)
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]