From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQkUD-0001dr-70 for qemu-devel@nongnu.org; Wed, 06 Jun 2018 22:17:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQkUC-0001hF-9R for qemu-devel@nongnu.org; Wed, 06 Jun 2018 22:17:13 -0400 Date: Thu, 7 Jun 2018 12:16:58 +1000 From: David Gibson Message-ID: <20180607021658.GB3166@umbus.fritz.box> References: <20180606152128.449-1-f4bug@amsat.org> <20180606152128.449-5-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QTprm0S8XgL7H0Dt" Content-Disposition: inline In-Reply-To: <20180606152128.449-5-f4bug@amsat.org> Subject: Re: [Qemu-devel] [PATCH 04/11] ppc/pnv: Add trailing '\n' to qemu_log() calls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: Alexander Graf , qemu-devel@nongnu.org, qemu-trivial@nongnu.org, qemu-ppc@nongnu.org --QTprm0S8XgL7H0Dt Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 06, 2018 at 12:21:21PM -0300, Philippe Mathieu-Daud=E9 wrote: > Signed-off-by: Philippe Mathieu-Daud=E9 I'm not really sure what series this was part of, but I've applied it to ppc-for-3.0 anyway. Acked-by: David Gibson > --- > hw/ppc/pnv_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c > index cbb64ad9e7..13ad7d9e04 100644 > --- a/hw/ppc/pnv_core.c > +++ b/hw/ppc/pnv_core.c > @@ -97,7 +97,7 @@ static uint64_t pnv_core_xscom_read(void *opaque, hwadd= r addr, > val =3D 0x24f000000000000ull; > break; > default: > - qemu_log_mask(LOG_UNIMP, "Warning: reading reg=3D0x%" HWADDR_PRI= x, > + qemu_log_mask(LOG_UNIMP, "Warning: reading reg=3D0x%" HWADDR_PRI= x "\n", > addr); > } > =20 > @@ -107,7 +107,7 @@ static uint64_t pnv_core_xscom_read(void *opaque, hwa= ddr addr, > static void pnv_core_xscom_write(void *opaque, hwaddr addr, uint64_t val, > unsigned int width) > { > - qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=3D0x%" HWADDR_PRIx, > + qemu_log_mask(LOG_UNIMP, "Warning: writing to reg=3D0x%" HWADDR_PRIx= "\n", > addr); > } > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --QTprm0S8XgL7H0Dt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAlsYlZoACgkQbDjKyiDZ s5Jktw//VPA1ICRkTZPd+upQLafmM3DOvW6KnODw4b9J2pByVSuP2LBboor0GGE9 n8ko0gPheyxHDYw20VbZywAhaBAJofago4wAOoFZAegbB+r+6ilbviru76xfB8gj C+BVKMEEc5wmg6aNkeJXyk+aNfL3UBxq7bj+XZz/jGKyjB/KwQY+cGIamj4QlsRm 1ft5LAIjLiRqeQrVqV7iWl2Z9MMZsmEzCJhxklBh3BRwR6u+DGFmyzDh61eoDwXM pBj0egGXq51kQM1GUGSjdR5BcwsI2cLuXZDHWt/MC/TsC4QViYqA2tQYThWM629+ BP15+LZOcpY9xegkKht0Ja69TJ6JFeprabB8aHxA1ReaBwid///tKgpRla90Z1B5 Xqpp3YzG+GcvQV7dfa/9AOuCplp4ljDW4wHX2e/aYdaZr/9KdPdgz5aCmpFFm8Do WtDyvuPNpMjwu/5hW5+LHiNnFV87sopjSt32Fu7EhUF4HtnLsWmxfLOD0VP0zAG/ 4Ymwc5vZuRlDmjQr5GpcjbcSBC6ehqcIyG5yjBCD4XliHiTVyTHsq8H5m/p14n7I XTvPEu5cZCKgND/3I91VcS3YOFCZmWc0F6gemeos+FJ6HCczKkzHpXhycwAihQK2 fsYuykeWMeNzsXGNjqdOI8rrk6uMIYUTIWSqYAuKPLDnyHI1wig= =ayVj -----END PGP SIGNATURE----- --QTprm0S8XgL7H0Dt--