From: Peter Xu <peterx@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com, imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode
Date: Thu, 7 Jun 2018 17:05:13 +0800 [thread overview]
Message-ID: <20180607090513.GO750@xz-mi> (raw)
In-Reply-To: <20180607090030.GC2522@work-vm>
On Thu, Jun 07, 2018 at 10:00:30AM +0100, Dr. David Alan Gilbert wrote:
> * Peter Xu (peterx@redhat.com) wrote:
> > On Tue, Jun 05, 2018 at 01:26:30PM +0100, Dr. David Alan Gilbert (git) wrote:
> > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > >
> > > Reenable HMP in preconfig mode; it's pretty
> > > easy and anyway I want to do a similar thing for OOB eventually.
> > > We'll want to enable more commands in preconfig mode to make it
> > > useful at some point.
> > >
> > > Dave
> >
> > Wanna add "quit" into the preconfig-allowed list for HMP as well?
>
> I tried; quit triggers a disallowed state transition!
Would it be understandable if we just avoid calling qmp_quit() when
during preconfig? An evil idea is, "exit()". :)
After all we have nothing there!
--
Peter Xu
next prev parent reply other threads:[~2018-06-07 9:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 12:26 [Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode Dr. David Alan Gilbert (git)
2018-06-05 12:26 ` [Qemu-devel] [PATCH 1/6] hmp: Add flag for preconfig commands Dr. David Alan Gilbert (git)
2018-06-07 8:50 ` Peter Xu
2018-06-07 12:14 ` Markus Armbruster
2018-06-07 12:18 ` Dr. David Alan Gilbert
2018-06-05 12:26 ` [Qemu-devel] [PATCH 2/6] hmp: Allow help on " Dr. David Alan Gilbert (git)
2018-06-07 8:51 ` Peter Xu
2018-06-05 12:26 ` [Qemu-devel] [PATCH 3/6] hmp: Restrict auto-complete in preconfig Dr. David Alan Gilbert (git)
2018-06-07 8:52 ` Peter Xu
2018-06-05 12:26 ` [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig Dr. David Alan Gilbert (git)
2018-06-07 8:49 ` Peter Xu
2018-06-07 12:22 ` Markus Armbruster
2018-06-07 13:45 ` Dr. David Alan Gilbert
2018-06-07 15:12 ` Markus Armbruster
2018-06-07 15:28 ` Dr. David Alan Gilbert
2018-06-08 5:56 ` Markus Armbruster
2018-06-08 8:18 ` Dr. David Alan Gilbert
2018-06-08 9:30 ` Igor Mammedov
2018-06-08 16:51 ` Markus Armbruster
2018-06-08 17:18 ` Dr. David Alan Gilbert
2018-06-07 15:08 ` Igor Mammedov
2018-06-08 5:41 ` Markus Armbruster
2018-06-07 9:39 ` Igor Mammedov
2018-06-05 12:26 ` [Qemu-devel] [PATCH 5/6] hmp: add exit_preconfig Dr. David Alan Gilbert (git)
2018-06-07 8:53 ` Peter Xu
2018-06-05 12:26 ` [Qemu-devel] [PATCH 6/6] hmp: Allow HMP in preconfig state again Dr. David Alan Gilbert (git)
2018-06-07 8:56 ` Peter Xu
2018-06-07 8:54 ` [Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode Peter Xu
2018-06-07 9:00 ` Dr. David Alan Gilbert
2018-06-07 9:05 ` Peter Xu [this message]
2018-06-07 9:45 ` Igor Mammedov
2018-06-07 10:02 ` Peter Xu
2018-06-07 9:48 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607090513.GO750@xz-mi \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).