From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQqrC-0002Vj-UF for qemu-devel@nongnu.org; Thu, 07 Jun 2018 05:05:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQqr7-00046z-T8 for qemu-devel@nongnu.org; Thu, 07 Jun 2018 05:05:22 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59230 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQqr7-00046G-Oc for qemu-devel@nongnu.org; Thu, 07 Jun 2018 05:05:17 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 60C82818AAE6 for ; Thu, 7 Jun 2018 09:05:17 +0000 (UTC) Date: Thu, 7 Jun 2018 17:05:13 +0800 From: Peter Xu Message-ID: <20180607090513.GO750@xz-mi> References: <20180605122636.33654-1-dgilbert@redhat.com> <20180607085444.GM750@xz-mi> <20180607090030.GC2522@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180607090030.GC2522@work-vm> Subject: Re: [Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: qemu-devel@nongnu.org, armbru@redhat.com, imammedo@redhat.com On Thu, Jun 07, 2018 at 10:00:30AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (peterx@redhat.com) wrote: > > On Tue, Jun 05, 2018 at 01:26:30PM +0100, Dr. David Alan Gilbert (git) wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Reenable HMP in preconfig mode; it's pretty > > > easy and anyway I want to do a similar thing for OOB eventually. > > > We'll want to enable more commands in preconfig mode to make it > > > useful at some point. > > > > > > Dave > > > > Wanna add "quit" into the preconfig-allowed list for HMP as well? > > I tried; quit triggers a disallowed state transition! Would it be understandable if we just avoid calling qmp_quit() when during preconfig? An evil idea is, "exit()". :) After all we have nothing there! -- Peter Xu