From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34929)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1fQrkV-0007NC-Vx
	for qemu-devel@nongnu.org; Thu, 07 Jun 2018 06:02:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1fQrkS-00082D-T7
	for qemu-devel@nongnu.org; Thu, 07 Jun 2018 06:02:32 -0400
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53900 helo=mx1.redhat.com)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <peterx@redhat.com>) id 1fQrkS-00081f-N0
	for qemu-devel@nongnu.org; Thu, 07 Jun 2018 06:02:28 -0400
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
	[10.11.54.3])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id A1C9640BC05B
	for <qemu-devel@nongnu.org>; Thu,  7 Jun 2018 10:02:27 +0000 (UTC)
Date: Thu, 7 Jun 2018 18:02:23 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20180607100223.GP750@xz-mi>
References: <20180605122636.33654-1-dgilbert@redhat.com>
	<20180607085444.GM750@xz-mi> <20180607114517.0148aa75@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180607114517.0148aa75@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>, qemu-devel@nongnu.org, armbru@redhat.com

On Thu, Jun 07, 2018 at 11:45:17AM +0200, Igor Mammedov wrote:
> On Thu, 7 Jun 2018 16:54:44 +0800
> Peter Xu <peterx@redhat.com> wrote:
> 
> > On Tue, Jun 05, 2018 at 01:26:30PM +0100, Dr. David Alan Gilbert (git) wrote:
> > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > > 
> > > Reenable HMP in preconfig mode; it's pretty
> > > easy and anyway I want to do a similar thing for OOB eventually.
> > > We'll want to enable more commands in preconfig mode to make it
> > > useful at some point.
> > > 
> > > Dave  
> > 
> > Wanna add "quit" into the preconfig-allowed list for HMP as well?
> There is exit-preconfig, but yeah it just forwards us to the next state
> 
> But for human users that just want to play with HMP 'quit'
> might be useful, but only to the extent of trying out things out.

Yes, actually I don't yet see a good reason to actually use HMP during
preconfig mode even as a whole.  But as Dave mentioned, it's too easy
to achieve that so I don't have a reason to object that too.

Regards,

-- 
Peter Xu